1769156 - Use content signature instead of cert pinning in the absence of the controlling pref

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, task, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

We currently use content signature checks if the media.gmp-manager.checkContentSignature pref is set to true, otherwise, if it's missing or false, we'll use cert pinning. Following bug 1760527 we should have that pref set everywhere. However we're seeing some telemetry that is showing cert pinning still being used in cases where we wouldn't expect.

While we investigate, I think it makes sense to also use content signature even if the pref isn't set. At the least it can't hurt.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1769156 - Use content sig checks for GMP updates if controlling pref is missing. r?gijs

Currently if the pref for using content sig checks with GMP updates is missing
we will use cert pinning. I.e. the default behaviour in the absence of a pref
value is cert pinning. This changes that so that we use content sig by default.

This is done as we're moving to content signatures as default behaviour, so it
makes sense to have it be the default if the pref is missing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a4bdda558ce
Use content sig checks for GMP updates if controlling pref is missing. r=Gijs

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5a4bdda558ce