Closed Bug 1769166 Opened 2 years ago Closed 2 years ago

Push updates to TextBounds

Categories

(Core :: Disability Access APIs, task)

Product:
Core
Component:
Disability Access APIs
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: morgan, Assigned: Jamie)

References

Details

(Whiteboard: [ctw-m2])

Crash Data

Attachments

(1 file)

Bug 1769166: Update the cache when text bounds change.
48 bytes, text/x-phabricator-request
Details | Review

TextBounds should update in a manner similar to bounds and text, like we do for line offsets :)

Blocks: 1735101
No longer depends on: 1735101
Blocks: a11y-ctw-text
Type: defect → task
Whiteboard: [ctw-m2]

Note that our failure to update the cache causes crashes when clients try to retrieve text bounds after text has mutated.

Crash Signature: [@ mozilla::detail::InvalidArrayIndex_CRASH | mozilla::a11y::TextLeafPoint::CharBounds ]

We detect this in the same way that we detect whether we need to push line starts; i.e. a text update or a bounds change.
Since this is tied to the Text and Bounds domains, I removed the separate TextBounds domain.

Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7945b5e5d756
Update the cache when text bounds change. r=morgan

https://hg.mozilla.org/mozilla-central/rev/7945b5e5d756

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: