1769250 - Check whether the addon is really present before trying to enable/disabling it

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P2)

Description

[Pier Angelo Vendrame]

Attachment: The patch for Firefox 91.9.0 ESR that we are using in Tor Browser; originally developed by Kathleen Brade

Hi! Bug 1488971 introduced some checks to see whether the addon is enabled, but doesn't check whether the addon was found in the first place.

In Tor Browser, for example, we remove it. Other forks may do the same.

Therefore, we would like to ask if you could add a check to return immediately from _checkScreenshotsPref (in browser/components/BrowserGlue.jsm) when addon is null.
Actually, also the async callback in _monitorWebcompatReporterPref in the same file would need a similar modification, in our opinion.

I am attaching the patch we use for Tor Browser (based on Firefox 91.9.0 ESR), please let me know if you think that it is okay and you want me to create a Phabricator patch, instead.

Thanks!

Comment 1

[Sam Foster [:sfoster] (he/him)]

(In reply to Pier Angelo Vendrame from comment #0)

I am attaching the patch we use for Tor Browser (based on Firefox 91.9.0 ESR), please let me know if you think that it is okay and you want me to create a Phabricator patch, instead.

Thanks for reporting this. I'm be happy to review that patch - can you submit it via phabricator?

Comment 2

[Pier Angelo Vendrame]

(In reply to Sam Foster [:sfoster] (he/him) from comment #1)

(In reply to Pier Angelo Vendrame from comment #0)

I am attaching the patch we use for Tor Browser (based on Firefox 91.9.0 ESR), please let me know if you think that it is okay and you want me to create a Phabricator patch, instead.

Thanks for reporting this. I'm be happy to review that patch - can you submit it via phabricator?

Great, thanks!

I will send you the patch via phabricator asap (I hope to do so in the next few days).

Comment 3

[Pier Angelo Vendrame]

Attachment: Bug 1769250: Check whether a built-in addon is really present before trying to enable/disabling it r=sfoster

Comment 4

[Pier Angelo Vendrame]

I have added the patch. I am still new to the phabricator/how to send you a patch, so I hope I have done everything correctly.

Otherwise, please let me know.

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/579e94f01c40
Check whether a built-in addon is really present before trying to enable/disabling it r=sfoster

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/579e94f01c40