1769295 - selfserv and tstclnt should use PR_GetPrefLoopbackAddrInfo

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement)

Description

[Kai Engert (:KaiE:)]

See bug 1769293 for the explanation.

selfserv should call PR_GetPrefLoopbackAddrInfo, and look at the returned family, to decide which socket family it should create for listening.

If tstclnt is configured to connect to localhost, it should call PR_GetPrefLoopbackAddrInfo to obtain AddrInfo of the preferred family. It can directly use it for connecting.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1769295 - selfserv and tstclnt should use PR_GetPrefLoopbackAddrInfo. r=rrelyea

Comment 2

[Kai Engert (:KaiE:)]

Bob, can you please test that this fix (latest patch) works in your environment?
I understand you have systems that fail to run the test suite without this change.

Comment 3

[Kai Engert (:KaiE:)]

https://treeherder.mozilla.org/jobs?repo=nss-try&revision=845806a441293ba2f32830e65db967272469a93c
[edited]

Comment 4

[Kai Engert (:KaiE:)]

Bob, could you please help with the follow up work? Are there leaks introduced?

Comment 5

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nss/rev/e3ac914bc684c080ba73f29b53a990f83308e37f

Comment 6

[Robert Relyea]

clearing need info

Comment 7

[Kai Engert (:KaiE:)]

Bob, the needinfo was for comment 2. Did you test?

Comment 8

[Robert Relyea]

The preliminary test worked (https://koji.fedoraproject.org/koji/taskinfo?taskID=87458626 x86_64 only ), the full fedora tests are running now: https://koji.fedoraproject.org/koji/taskinfo?taskID=87484208 . (not clearing need info until the latter tests have completed).

Comment 9

[Robert Relyea]

OK, The build finished on all platforms (including running all.sh tests), so I think we are good.