make clearHistory & clearSiteData match clearOnShutdown and not remove `persist-data-on-shutdown` exceptions
Categories
(Toolkit :: Data Sanitization, enhancement, P5)
Tracking
()
People
(Reporter: thorin, Unassigned)
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
Steps to reproduce:
Same as Bug 1681701
privacy.clearOnShutdown* and privacy.cpd should follow the same behavior. For site exceptions, users can still manage and clear site data from the Cookies and Site Data section of the UI
| Reporter | ||
Updated•4 years ago
|
| Reporter | ||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
I think this is a nice feature, given that users know that sites they have given "cookie" permissions are not cleared. So if we implement this we should also add a checkbox to toggle these exceptions on/off or at least a warning message: "X sites / these sites are exempt and will not be cleared".
Updated•4 years ago
|
| Reporter | ||
Updated•1 month ago
|
| Reporter | ||
Updated•1 month ago
|
| Reporter | ||
Comment 3•1 month ago
|
||
Comment 4•14 days ago
|
||
It's been a while and looking at the bug I'm not sure what exactly we want to do here. Has this been addressed by the recent switch to a dedicated clear on shutdown exception permission?
Comment 5•14 days ago
|
||
Does "Clear recent history" with privacy.cpd.cookies = true honor exceptions (either classic cookie permissions or newer persist-data-on-shutdown permissions)? This isn't indicated in the dialog one way or the other. In a perfect world, there might be an indented checkbox for following or overriding the user's exceptions.
| Reporter | ||
Comment 6•14 days ago
|
||
(In reply to jscher2000 from comment #5)
Does "Clear recent history" with
privacy.cpd.cookies= true honor exceptions
No, next bit. Note: cpd is obsolete, it's been migrated to clearHistory - e.g. privacy.clearHistory.cookiesAndStorage
(In reply to Emma Zühlcke [:emz] from comment #4)
It's been a while and looking at the bug I'm not sure what exactly we want to do here. Has this been addressed by the recent switch to a dedicated clear on shutdown exception permission?
Sure has been a while :) and no AFAICT
For those following along at home, there are three global methods to sanitize (i.e ignoring site specific Forget about this site)
clearOnShutdown_v2-> automatic withsanitizeOnShutdown- items map to options in
History>Choose...>Settings
- items map to options in
clearSiteData-> manual -> items map to options inPrivacy and security>Browsing data>Clear browsing dataclearHistory-> manual -> items map to options inctrl-shift-del
How these three behave should be universal IMO
This issue was that the two manual methods, when clearing cookiesAndStorage would not respect the site exception
this needs re-testingthis still seems to be the case- so divergent behavior: auto-sanitize I keep expected site cookies/data .. manually I unexpectedly lose them
Another issue is that the two manual methods, clearing siteSettings also removes the site exception
- so divergent behavior: auto-sanitize I keep site exceptions .. manually I unexpectedly lose them
unexpectedly lose them-> see https://bugzilla.mozilla.org/show_bug.cgi?id=2065902#c29
It would be nice to align the behavior here
| Reporter | ||
Comment 7•13 days ago
|
||
without wanting to compound anything, so feel free to ignore ... I wonder why we even need clearHistory anymore - just make the ctrl-shift-del dialog's options map to clearSiteData - i.e you can go to Privacy and security>Browsing data>Clear browsing data if you're in settings .. or shortcut to it with ctrl-shift-del from any origin. They both serve the exact same functionality - they're manual, one-offs, and you change what is cleared each time (e.g when testing/dev work). Unless I'm missing something this would simplify code/tests - yes?
Description
•