1769346 - [wpt-sync] Sync PR 34064 - Reland "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34064 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34064
Details from upstream follow.

Ari Chivukula <[e-mail]> wrote:

Reland "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default"

This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568.

Reason for revert: Fixing broken bots, underlying change is correct one

Original change's description:

Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default"

This reverts commit caff7911aeddc8d231dc335715d1dda404320f67.

Reason for revert: Failing multiple bots

Original change's description:

[Cookie Expires/Max-Age Upper Limit] (3) Enable by default

This won't be committed until after shipping is approved.
For now, this is just for vetting.

This CL is a part of a series:
(1) Add new UMA
(2) Implement limit behind flag
(3) Enable by default

Spec:
https://github.com/httpwg/http-extensions/pull/1732

Bug: 1264458
Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385
Reviewed-by: Christian Dullweber \<[e-mail]>
Reviewed-by: Clark DuVall \<[e-mail]>
Auto-Submit: Ari Chivukula \<[e-mail]>
Reviewed-by: David Roger \<[e-mail]>
Reviewed-by: Steven Bingler \<[e-mail]>
Commit-Queue: Ari Chivukula \<[e-mail]>
Reviewed-by: Kenichi Ishibashi \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1003286}

Bug: 1264458, 1325493
Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321
Commit-Queue: Lijin Shen \<[e-mail]>
Owners-Override: Lijin Shen \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1003366}

Bug: 1264458, 1325493
Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf

Reviewed-on: https://chromium-review.googlesource.com/3645552
WPT-Export-Revision: 9a272589b48400ab5e4a75ee3dfac7e3d2e377d4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a4b054a90e760b0192d76bc78d1e2e8bd257a62

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 10 subtests

Status Summary

Firefox

OK : 2
FAIL: 20

Chrome

OK : 2
PASS: 16
FAIL: 4

Safari

OK : 2
FAIL: 20

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /cookie-store/cookieListItem_attributes.https.any.html [wpt.fyi]
  • CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
  • CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
  • CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
• /cookie-store/cookieListItem_attributes.https.any.serviceworker.html [wpt.fyi]
  • CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
  • CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: FAIL, Safari: FAIL)
  • CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
  • CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/903e182c6f5d
[wpt PR 34064] - Reland "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default", a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/903e182c6f5d