1769485 - Assert that we do not skip ShutdownPhase::XPCOMShutdown due to a missing service manager

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Jens Stutte [:jstutte]]

We advance to ShutdownPhase::XPCOMShutdown only if we find the service manager.

The current code looks as if we would treat the error, but we actually do not expect this to be ever missing at this stage of shutdown and just skipping it would be bad. Thus we want to add a MOZ_DIAGNOSTIC_ASSERT here to see if our assumptions hold.

Comment 1

[Seweryn Pajor]

I would like to work on this bug.

Comment 2

[Seweryn Pajor]

Attachment: XPCOMInit.cpp

I tried to fix the bug. I am new to Mozilla community so I would like to ask for some guidance.

Comment 3

[Jens Stutte [:jstutte]]

Hi! Great that you want to help!
However, you should submit a patch, not just a modified source file. Please use moz-phab to submit the patch, such that we can do the review inside phabricator which eases life for all of us.
Please be sure to have read Firefox Contributors’ Quick Reference and possibly Sending your code for review (also known as “sending patches”). It can feel kind of overwhelming at the beginning, but it definitely pays off once you are through it.
Thanks for your support!

Comment 4

[Seweryn Pajor]

I'm sorry, you're right. I will send a patch file in a moment

Comment 5

[Seweryn Pajor]

Attachment: Bug 1769485 - Replace if statement checking if service manager is present with MOZ_DIAGNOSTIC_ASSERT. r?#xpcom-reviewers

Comment 6

[Seweryn Pajor]

Attachment: Bug 1769485 - Replace if statement checking if service manager is present with MOZ_DIAGNOSTIC_ASSERT. r?#xpcom-reviewers

Comment 7

[Seweryn Pajor]

Attachment: Bug 1769485 - Replace if statement checking if service manager is present with MOZ_DIAGNOSTIC_ASSERT. r?#xpcom-reviewers

Comment 8

[Jens Stutte [:jstutte]]

Hi, sorry for the hassle! I just realized that you seem to use git, not mercurial. Honestly I do not know how to configure that to work correctly with moz-phab - I am sure there is a way, though. I'll ask around.

Comment 9

[Jens Stutte [:jstutte]]

please try to look at https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-email-address-for-every-repository-on-your-computer

Comment 10

[Jens Stutte [:jstutte]]

that will set the metadata and then it's necessary to amend the commit like git commit --amend --reset-author

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b8326b00bed
Replace if statement checking if service manager is present with MOZ_DIAGNOSTIC_ASSERT. r=xpcom-reviewers,jstutte

Comment 12

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/1b8326b00bed

Comment 13

[Jens Stutte [:jstutte]]

Congrats!