1769569 - Enable ESLint rules no-undef, no-unused-vars and mozilla/use-cc-etc for sjs files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

Enabling more rules for sjs files

Comment 1

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=c8076d91a6d2a13617a5071001552b40d5e9b2f5

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1769569 - Enable ESLint rule no-define-cc-etc for devtools sjs files. r?jdescottes

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1769569 - Make use-cc-etc auto-fixable. r?Gijs

Depends on D146449

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1769569 - Automatically replace Components.* with C* in sjs files. r?Gijs

Depends on D146450

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1769569 - Fix remaining ESLint no-undef and no-unused-vars issues in sjs files. r?Gijs

Depends on D146451

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1769569 - Disable reject-importGlobalProperties for sjs files via the ESLint rule. r?Gijs

Depends on D146450

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aed34fdf2d3
Enable ESLint rule no-define-cc-etc for devtools sjs files. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/29d8dd058b7a
Make use-cc-etc auto-fixable. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/edcd3dade079
Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d3cc9629cd9a
Automatically replace Components.* with C* in sjs files. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/66a42eb3a366
Fix remaining ESLint no-undef and no-unused-vars issues in sjs files. r=Gijs

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for causing devtools' browser/browser_page_redirection.js to fail:

https://hg.mozilla.org/integration/autoland/rev/a7e45bcab84845674f1f0328ca5430606609e459

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=66a42eb3a3664fef1798920a2915f525f0cf9747&selectedTaskRun=S684CyAvTpS6AqLi-68phw.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=378378682&repo=autoland

TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/browser/browser_page_redirection.js | Test timed out -

Comment 9

[Mark Banner (:standard8)]

It would help if I didn't remove extra lines when I remove some no longer needed eslint-disable-next-line comments...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8777c1019002
Enable ESLint rule no-define-cc-etc for devtools sjs files. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/fd92487387bd
Make use-cc-etc auto-fixable. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/47265cc6e820
Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/0323be8b5132
Automatically replace Components.* with C* in sjs files. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c460b3e1bbd0
Fix remaining ESLint no-undef and no-unused-vars issues in sjs files. r=Gijs

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8777c1019002
https://hg.mozilla.org/mozilla-central/rev/fd92487387bd
https://hg.mozilla.org/mozilla-central/rev/47265cc6e820
https://hg.mozilla.org/mozilla-central/rev/0323be8b5132
https://hg.mozilla.org/mozilla-central/rev/c460b3e1bbd0