1769583 - Add telemetry for the adaptive history autofill pref

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

We should add telemetry for the adaptive history autofill pref, browser.urlbar.autoFill.adaptiveHistory.enabled. The most straightforward kind would be the userPrefs section of environment data.

Comment 1

[Drew Willcoxon :adw]

No reason not to include browser.urlbar.autoFill too.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1769583 - Add the urlbar autofill prefs to telemetry environment data.

Comment 3

[Drew Willcoxon :adw]

Attachment: data-request.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9276798 [details]
data-request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Drew Wilcoxon is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5645da636b4c
Add the urlbar autofill prefs to telemetry environment data. r=chutten

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5645da636b4c

Comment 7

[Drew Willcoxon :adw]

STR:

1. Set the following prefs:

   browser.urlbar.autoFill = true (will be true already on a new profile)
   browser.urlbar.autoFill.adaptiveHistory.enabled = true
   

2. Open about:telemetry#environment-data-tab_search=browser.urlbar.autoFill
3. Verify the following values appear:
   • userPrefs.browser.urlbar.autoFill: true
   • userPrefs.browser.urlbar.autoFill.adaptiveHistory.enabled: true
4. Set the prefs to false:

   browser.urlbar.autoFill = false
   browser.urlbar.autoFill.adaptiveHistory.enabled = false
   

5. Open about:telemetry#environment-data-tab_search=browser.urlbar.autoFill again or reload the tab from step 2
6. Verify the values are now false:
   • userPrefs.browser.urlbar.autoFill: false
   • userPrefs.browser.urlbar.autoFill.adaptiveHistory.enabled: false

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I can confirm this task is implemented on Nightly 102.0a1(20220522190601). Tested on macoS 11, Windows 10 x64 and Ubuntu 20.04.