1769693 - Crash in [@ mozilla::ipc::PortLink::SendMessage | IPC_Message_Name=PContent::Msg_ShutdownProfile]

Status: RESOLVED DUPLICATE of bug 1761578

(Core :: Gecko Profiler, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/aa83a7f4-4d98-48b7-ace6-26ecf0220513

MOZ_CRASH Reason: MOZ_CRASH(IPC message size is too large)

Top 10 frames of crashing thread:

0 xul.dll mozilla::ipc::PortLink::SendMessage ipc/glue/MessageLink.cpp:98
1 xul.dll mozilla::ipc::MessageChannel::SendMessageToLink ipc/glue/MessageChannel.cpp:783
2 xul.dll mozilla::ipc::MessageChannel::Send ipc/glue/MessageChannel.cpp:772
3 xul.dll mozilla::ipc::IProtocol::ChannelSend ipc/glue/ProtocolUtils.cpp:487
4 xul.dll mozilla::dom::PContentChild::SendShutdownProfile ipc/ipdl/PContentChild.cpp:4940
5 xul.dll mozilla::dom::ContentChild::ShutdownInternal dom/ipc/ContentChild.cpp:3105
6 xul.dll mozilla::dom::ContentChild::RecvShutdown dom/ipc/ContentChild.cpp:3034
7 xul.dll mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:12272
8 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:1706
9 xul.dll mozilla::ipc::MessageChannel::RunMessage ipc/glue/MessageChannel.cpp:1506

One thing worth noting about this crash is that it's a 32-bit build on a modern machine.

Comment 1

[Jens Stutte [:jstutte]]

(In reply to Gabriele Svelto [:gsvelto] from comment #0)

One thing worth noting about this crash is that it's a 32-bit build on a modern machine.

Do we have different IPC message sizes on 32 Bit ?

Anyhow, looking at the stack it seems to me that we do mProfilerController->GrabShutdownProfileAndShutdown() on shutdown and pass the returned string directly into the SendShutdownProfile without any precautions against being too long.

Comment 2

[Jens Stutte [:jstutte]]

See bug 1330185 where this has been first introduced.

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Jens Stutte [:jstutte] from comment #1)

Do we have different IPC message sizes on 32 Bit ?

No, the message limit is hard coded.