Closed Bug 1769729 Opened 2 years ago Closed 2 years ago

Download toolbar icon doesn't close if pressing accel-w to close a tab

Categories

(Firefox :: Downloads Panel, defect)

Product:
Firefox
Component:
Downloads Panel
Version:
Firefox 100
Platform:
Unspecified
All
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox100 --- affected
firefox101 --- affected
firefox102 --- affected

People

(Reporter: rezganj, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

I have a download icon (button) on my toolbar. Before v100 the popup window it opened would close automatically. Now it remains open - very annoying and takes realestate and even stays across tabs. To reproduce:

  1. add download button to Firefox toolbar - looks like a downward arrow pointing into an upward bracket.

  2. download something

  3. it opens a popup containing past downloads

  4. Before v100 it would then close but now it stays open when the tab is closed.

  5. Close the tab

  6. The open download list popup still remains open eventhough the tab has been closed and it consumes realestate on the next tab - very annoying.

It should close when the tab is closed and not remain open.

Actual results:

see steps above. open download popup stays open even when tab is closed. prior to v100 it used to close.

Expected results:

download popup should have closed when tab is closed.

So if you close that tab the download window remains open (a bug) - and if you close the subsequent tabs the same download window dropdown remains open - very annoying. This did NOT happen prior to V100.

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Downloads Panel

Hi,

I wasn't able to reproduce the issue , the download panel disappears when I either close or switch from the tab I started the download from.

Could you check if this also occurs in troubleshooting-mode? Here is a link that can help you with that:
https://support.mozilla.org/en-US/kb/diagnose-firefox-issues-using-troubleshoot-mode

Thanks!

Flags: needinfo?(rezganj)

(In reply to Peter_M from comment #3)

Hi,

I wasn't able to reproduce the issue , the download panel disappears when I either close or switch from the tab I started the download from.

Could you check if this also occurs in troubleshooting-mode? Here is a link that can help you with that:
https://support.mozilla.org/en-US/kb/diagnose-firefox-issues-using-troubleshoot-mode

Thanks!

Hi Peter
Thanks for the note. I am in troubleshooting mode now and it does happen again. I can recreate it every time.
e.g.

  • command s to save current page
  • opens download dropdown/popup
  • shows the page was saved
  • command w to close the tab
  • popup remains open

prior to v 100 this didn't happen. it's annoying. thanks

Flags: needinfo?(rezganj)

I was able to reproduce this way, it seems to be only happening when you close the tab with cmd+w.

Thank you for the detailed steps.

Status: UNCONFIRMED → NEW
status-firefox100: --- → affected
status-firefox101: --- → affected
status-firefox102: --- → affected
Ever confirmed: true
OS: Unspecified → All

(In reply to Peter_M from comment #5)

I was able to reproduce this way, it seems to be only happening when you close the tab with cmd+w.

Thank you for the detailed steps.

My pleasure. Thanks for taking note. Cmd-W is my common way of closing most things :-)
Closing the tab by tapping on it will make the popup close since it closes on any tap it seems but Cmd-W doesn't require tapping.
Hope it gets fixed.
Best regards
Reza

I expect there's some people who will treat this as a feature. For instance, you can download a file on one tab, then switch tabs with the keyboard and then mouse-drag a download to the web content in that tab.

The downloads popup content isn't tab-specific (so tabs closing shouldn't automatically hide the popup - this is also important because tabs can in certain cases be closed by web content, and it'd be frustrating if the popup closed without any user interaction, esp. if you were about to interact with it).

Likewise, arbitrary keypresses shouldn't automatically close all popups - you can interact with the content of the downloads panel with the keyboard (arrow keys + space, context menu shortcut on non-mac, possibly copy/paste in the future).

So I don't think we should do anything here.

If you want to close the popup with the keyboard, [esc] will do that for you.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Summary: Download toolbar icon doesn't close as it used to prior to version 100 - very annoying. Can recreate (see below) → Download toolbar icon doesn't close if pressing accel-w to close a tab

(In reply to :Gijs (he/him) from comment #7)

I expect there's some people who will treat this as a feature. For instance, you can download a file on one tab, then switch tabs with the keyboard and then mouse-drag a download to the web content in that tab.

The downloads popup content isn't tab-specific (so tabs closing shouldn't automatically hide the popup - this is also important because tabs can in certain cases be closed by web content, and it'd be frustrating if the popup closed without any user interaction, esp. if you were about to interact with it).

Likewise, arbitrary keypresses shouldn't automatically close all popups - you can interact with the content of the downloads panel with the keyboard (arrow keys + space, context menu shortcut on non-mac, possibly copy/paste in the future).

So I don't think we should do anything here.

If you want to close the popup with the keyboard, [esc] will do that for you.

I buy that :-)

(In reply to :Gijs (out until June 8; he/him) from comment #7)

I expect there's some people who will treat this as a feature. For instance, you can download a file on one tab, then switch tabs with the keyboard and then mouse-drag a download to the web content in that tab.

The downloads popup content isn't tab-specific (so tabs closing shouldn't automatically hide the popup - this is also important because tabs can in certain cases be closed by web content, and it'd be frustrating if the popup closed without any user interaction, esp. if you were about to interact with it).

Likewise, arbitrary keypresses shouldn't automatically close all popups - you can interact with the content of the downloads panel with the keyboard (arrow keys + space, context menu shortcut on non-mac, possibly copy/paste in the future).

So I don't think we should do anything here.

If you want to close the popup with the keyboard, [esc] will do that for you.

I do a lot of downloading / local saving and this persistent popup is very annoying. It adds an extra click to things I often do so it's "resource intensive". My option is to get rid of that icon on the tool bar but then I don't know if downloads are done/ active or not - sometimes they fail and I don't want to bother going to download page to check. Having the popup disappear like it used to before version 100 is best.

(In reply to REZA GANJAVI from comment #9)

My option is to get rid of that icon on the tool bar but then I don't know if downloads are done/ active or not - sometimes they fail and I don't want to bother going to download page to check. Having the popup disappear like it used to before version 100 is best.

FWIW, the popup didn't even appear at all before 98 (except for the very first download, to show you where it was), and nothing changed wrt the popup behaviour in 100.

If you don't want the popup to appear at all, you can set the pref (browser.download.alwaysOpenPanel in about:config) to make it not appear. We're adding UI (context menu on the button) for this pref in Firefox 102.

(In reply to :Gijs (out until June 8; he/him) from comment #10)

Wow fantastic. Case definitely closed. Issue solved. You're a champ. It works like a champ :-)

You need to log in before you can comment on or make changes to this bug.