Closed
Bug 176985
Opened 23 years ago
Closed 23 years ago
nsHTMLDocument::SetDomain() can leak an nsIURI
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: keeda, Assigned: jst)
Details
(Keywords: memory-leak, Whiteboard: [HAVE FIX])
Attachments
(1 file)
|
1.05 KB,
patch
|
peterv
:
review+
bzbarsky
:
superreview+
roc
:
approval+
|
Details | Diff | Splinter Review |
nsHTMLDocument::SetDomain() uses a raw pointer to a newly created nsIURI, and
doesnt care to release when it is done. This results in a small leak.
Trivial fix is coming up.
|
Reporter | |
Comment 1•23 years ago
|
||
|
|
Reporter | |
Updated•23 years ago
|
|
||
Comment 2•23 years ago
|
||
Comment on attachment 104316 [details] [diff] [review]
convert to nsCOMPtr and plug the leak
r=peterv
Attachment #104316 -
Flags: review+
|
|
||
Updated•23 years ago
|
Attachment #104316 -
Flags: superreview+
|
|
||
Comment 3•23 years ago
|
||
Comment on attachment 104316 [details] [diff] [review]
convert to nsCOMPtr and plug the leak
sr=bzbarsky
|
|
||
Comment 4•23 years ago
|
||
Go ahead and ask for approval for this, please.
|
Assignee | |
Updated•23 years ago
|
Whiteboard: [HAVE FIX]
Comment on attachment 104316 [details] [diff] [review]
convert to nsCOMPtr and plug the leak
a=roc+moz for trunk
Attachment #104316 -
Flags: approval+
|
|
||
Comment 6•23 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•