1769867 - Rewrite test_bug590870.html and test_bug590812.html to not depend on ambient allowXULXBL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Andrew McCreight [:mccr8]]

I've rewritten test_bug590870.html and test_bug590812.html to use SpecialPowers.pushPermissions to set allowXULXBL to true and false as needed, instead of depending on it being set to true everywhere, except for noxul.example.com where it is false.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1769867, part 1 - Rewrite test_bug590870.html and test_bug590812.html to not depend on ambient allowXULXBL.

Comment 2

[Andrew McCreight [:mccr8]]

Joel, do you know how I can run testing/mozbase/mozprofile/tests/test_profile_view.py locally? My patch here removes the only two uses of noxul, so I could remove this mechanism from testing/mozbase/mozprofile/mozprofile/permissions.py, but it looks like there's a test for that, so I'd have to fix the test, but if I do ./mach python-test testing/mozbase/mozprofile/tests/test_permissions.py I get an exception like "ValueError: Plugin already registered: mozlog=<module 'mozlog.pytest_mozlog.plugin' from '/Users/andrewmccreight/mc/testing/mozbase/mozlog/mozlog/pytest_mozlog/plugin.py'>"

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1769867, part 2 - Don't test for XUL in test_title.html.

There's a similar chrome test for this functionality, test_title.xhtml,
and I think we don't care too much about the correctness of in-content
XUL at this point. We want to avoid enabling XUL during tests.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1769867, part 3 - Don't add a XUL document in test_bug396843.html.

It looks like this is just added in to test a bunch of stuff,
but this causes the test to break if allowXULXBL is not set,
so just remove it.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

this is relatively simple if you know the magic command:
./mach python-test --subsuite mozbase testing/mozbase/mozprofile/tests/test_profile_view.py

Comment 6

[Andrew McCreight [:mccr8]]

That command hits the same error for me, unfortunately.

There are more tests that depend on allowXULXBL, but I can file a new bug for those.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbde66bb52b2
part 1 - Rewrite test_bug590870.html and test_bug590812.html to not depend on ambient allowXULXBL. r=kmag
https://hg.mozilla.org/integration/autoland/rev/43cfd48f2a7c
part 2 - Don't test for XUL in test_title.html. r=kmag
https://hg.mozilla.org/integration/autoland/rev/5bebf6e23891
part 3 - Don't add a XUL document in test_bug396843.html. r=smaug

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/bbde66bb52b2
https://hg.mozilla.org/mozilla-central/rev/43cfd48f2a7c
https://hg.mozilla.org/mozilla-central/rev/5bebf6e23891