17699 - Remove obsolete functions PR_SetThreadExit and PR_GetThreadExit

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Wan-Teh Chang]

The functions PR_SetThreadExit and PR_GetThreadExit are
declared in private/pprthred.h and are intended to support
per-thread exit functions.  However, their implementation
in pr/src/threads/prtpd.c is commented out.  This means
no NSPR clients can possibly be using these two functions.
Also, per-thread exit functions can be emulated by
thread-private data destructors.  Therefore, I propose
that these two functions be removed.

The following needs to be removed:
Functions: PR_SetThreadExit, PR_GetThreadExit
Data types: PRThreadExit, _PRPerThreadExit
Fields of PRThread: numExits, ptes

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[Wan-Teh Chang]

The fix is checked in.
/cvsroot/mozilla/nsprpub/pr/include/private/pprthred.h, revision 3.4
/cvsroot/mozilla/nsprpub/pr/include/private/primpl.h, revision 3.26
/cvsroot/mozilla/nsprpub/pr/src/threads/prcthr.c, revision 3.9
/cvsroot/mozilla/nsprpub/pr/src/threads/prtpd.c, revision 3.6
/cvsroot/mozilla/nsprpub/pr/src/threads/combined/pruthr.c, revision 3.15

Also checked into the internal repository.
/m/src/ns/nspr20/pr/include/private/pprthred.h, revision 2.5
/m/src/ns/nspr20/pr/include/private/primpl.h, revision 2.67
/m/src/ns/nspr20/pr/src/threads/prcthr.c, revision 2.14
/m/src/ns/nspr20/pr/src/threads/prtpd.c, revision 2.9
/m/src/ns/nspr20/pr/src/threads/combined/pruthr.c, revision 2.32