1770067 - Fix promo button to support link styling and href attribute

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

With fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1761842, promo CTA started using button element instead of anchor tag. This broke the flow that relied on using href attribute to open promoLinkURL used by VPN Promo.

https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#113

Fix of bug https://bugzilla.mozilla.org/show_bug.cgi?id=1770061 will allow opening URL using SpecialMessageActions API. Scope of this bug is to evaluate a) advantage of href navigation, b) if we want to keep styling for promo button as link vs button and accordingly cleanup the code.

https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#109

Comment 1

[Punam Dahiya [:pdahiya]]

Marking P2 in favor of no immediate requirement for styling promo button as link

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Jason Prickett]

Attachment: Bug 1770067 - Adding link support to private browsing promo button r?pdahiya,emcminn

Comment 4

[Jason Prickett]

Using an <a> tag with tabindex="0" here supports both cases of having either an anchor or a button, however it interrupts the accessibility of the button slightly.

Adding a role to the anchor in the case of it acting as a button, and adding a keyup handler to handle space and enter key events in the same way as click events brings this back into the realm of accessible.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/074332a16756
Adding link support to private browsing promo button r=pdahiya,emcminn

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/074332a16756