1770195 - cleanup private method / internal command declarations in windowglobal/log.jsm

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Julian Descottes [:jdescottes]]

We are now using private methods in webdriver bidi modules. Methods starting with an underscore are supposed to be internal commands.

_getLogEntryLevelFromConsoleMethod was probably created before we started to follow this rule, but it's now confusing because it looks like it's an internal command whereas it's just a private method.

https://searchfox.org/mozilla-central/rev/7f729f601c0b738f870ae0ed49098f9268e250f9/remote/webdriver-bidi/modules/windowglobal/log.jsm#198

Should be renamed to #getLogEntryLevelFromConsoleMethod and moved before #onConsoleAPIMessage for fix alphabetical sorting of methods.

Also the comments in the file are incorrect: https://searchfox.org/mozilla-central/rev/7f729f601c0b738f870ae0ed49098f9268e250f9/remote/webdriver-bidi/modules/windowglobal/log.jsm#51 should actually say "Internal commands", and the 3 internal commands should be declared at the end of the class (see https://searchfox.org/mozilla-central/source/remote/webdriver-bidi/modules/windowglobal/browsingContext.jsm for a proper example).

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770195 - [bidi] cleanup method declarations in windowglobal/log.jsm

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8d5494dd1a5
[bidi] cleanup method declarations in windowglobal/log.jsm r=webdriver-reviewers,whimboo

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d8d5494dd1a5