Closed Bug 1770205 Opened 2 years ago Closed 2 years ago

Flag SOURCE resources for inline sources and flag debugger frontend sources for HTML sources

Categories

(DevTools :: Debugger, enhancement)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1770205 - [devtools] Flag SOURCE resources for inline sources and flag debugger frontend sources for HTML sources. r=nchevobbe
48 bytes, text/x-phabricator-request
Details | Review

Flag SOURCE resources for inline sources and flag debugger frontend sources for HTML sources

Summary: Add getLocationSource selector to fetch source for a location → Flag SOURCE resources for inline sources and flag debugger frontend sources for HTML sources

In the frontend we end up having special sources, related to many source actors.
These are the sources for HTML pages, which have one unique source object.
But each inline <script> tag will have its own source actor.
All these sources actors will be bound to this unique source for the HTML page.

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad44d2e50491
[devtools] Flag SOURCE resources for inline sources and flag debugger frontend sources for HTML sources. r=nchevobbe

Backed out for devtools failures on browser_dbg-html-breakpoints.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=JqI2CVTQQhmHDche8I8qZw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=ad44d2e504910a01b6ac44806780318aae962c5b

Failure log: https://treeherder.mozilla.org/logviewer?job_id=379096240&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/43ac17a9f0e23a760644d31e76b49ecdac141410

[task 2022-05-24T11:03:22.930Z] 11:03:22     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-html-breakpoints.js | a new breakpoint was created - 
[task 2022-05-24T11:03:22.931Z] 11:03:22     INFO - Navigating to "https://example.com/browser/devtools/client/debugger/test/mochitest/examples/doc-html-breakpoints.html"
[task 2022-05-24T11:03:22.931Z] 11:03:22     INFO - Wait for the toolbox to reload
[task 2022-05-24T11:03:22.932Z] 11:03:22     INFO - Waiting for toolbox commands to be reloaded…
[task 2022-05-24T11:03:22.932Z] 11:03:22     INFO - Waiting for target switch…
[task 2022-05-24T11:03:22.933Z] 11:03:22     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "https://example.com/browser/devtools/client/debugger/test/mochitest/examples/doc-html-breakpoints.html" line: 0}]
[task 2022-05-24T11:03:22.934Z] 11:03:22     INFO - → switched-target emitted
[task 2022-05-24T11:03:22.934Z] 11:03:22     INFO - Waiting for 'dom-loading' resource…
[task 2022-05-24T11:03:22.935Z] 11:03:22     INFO - → 'dom-loading' resource emitted
[task 2022-05-24T11:03:22.936Z] 11:03:22     INFO - Wait for Responsive UI to reload
[task 2022-05-24T11:03:22.937Z] 11:03:22     INFO - Waiting on sources: doc-html-breakpoints.html, html-breakpoints-slow.js
[task 2022-05-24T11:03:22.938Z] 11:03:22     INFO - Waiting for state change: source doc-html-breakpoints.html exists
[task 2022-05-24T11:03:22.939Z] 11:03:22     INFO - Waiting for state change: source html-breakpoints-slow.js exists
[task 2022-05-24T11:03:22.940Z] 11:03:22     INFO - Finished waiting for state change: source doc-html-breakpoints.html exists
[task 2022-05-24T11:03:22.941Z] 11:03:22     INFO - Finished waiting for state change: source doc-html-breakpoints.html exists
[task 2022-05-24T11:03:22.942Z] 11:03:22     INFO - Buffered messages finished
[task 2022-05-24T11:03:22.943Z] 11:03:22     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-html-breakpoints.js | Test timed out - 
[task 2022-05-24T11:03:22.951Z] 11:03:22     INFO - Removing tab.
[task 2022-05-24T11:03:22.953Z] 11:03:22     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2022-05-24T11:03:22.962Z] 11:03:22     INFO - Got event: 'TabClose' on [object XULElement].
[task 2022-05-24T11:03:22.972Z] 11:03:22     INFO - Tab removed and finished closing
[task 2022-05-24T11:03:22.977Z] 11:03:22     INFO - GECKO(1628) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2022-05-24T11:03:22.983Z] 11:03:22     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-05-24T11:03:22.986Z] 11:03:22     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-html-breakpoints.js | The main process DevToolsServer has no pending connection when the test ends -
Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6cdecf32821b
[devtools] Flag SOURCE resources for inline sources and flag debugger frontend sources for HTML sources. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/6cdecf32821b

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Flags: needinfo?(hmanilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: