1770241 - Utility process child blocked on startup from audio utility

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[:gerard-majax]

+++ This bug was initially created as a clone of Bug #1769624 +++

Reverting the fix of bug 1770086 one should repro intermittent leak of sLaunchUtilityPromise. Investigation showed so far that on osx at least, we get the child process unable to start, somehow blocking around https://searchfox.org/mozilla-central/rev/7f729f601c0b738f870ae0ed49098f9268e250f9/ipc/glue/ProcessUtils_mac.mm#20

This should be investigated further

Comment 1

[:gerard-majax]

We would also need to address https://phabricator.services.mozilla.com/D146848#inline-809936

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:gerard-majax, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 3

[:gerard-majax]

Removing completely the SetThisProcessName() seems to help: https://treeherder.mozilla.org/jobs?repo=try&revision=304e452ecc0ed36c438fb31d67684eb42bc997c7

After 456 retriggers, no repro, while https://treeherder.mozilla.org/jobs?repo=try&revision=78e26d2a0d02d937a01bc4741b3e1837d3dc309d would show ~3 repro over 50 runs.

According to https://bugzilla.mozilla.org/show_bug.cgi?id=557226#c14 we need to set the name after doing GetCurrentProcess() and I verified that if we just remove GetCurrentProcess() no name is changed in Activity Monitor.

However reading System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/Headers/Processes.h about GetCurrentProcess() one can see:

• An application can force the connection to the Process Manager to
• be set up by calling any Process Manager routine, but the
• recommended way to do this is to call GetCurrentProcess() to ask
• for the current application's PSN. This will initialize the
• connection to the Process Manager if it has not already been set
• up and 'check in' the application with the system.

Right now we do the call, for Utility Process, within the UtilityProcessChild::Init() https://searchfox.org/mozilla-central/rev/49204d3e4b03513ca2741404b7453245863d380c/ipc/glue/UtilityProcessChild.cpp#105

But it looks like if we do it in RecvInit() before calling CGSShutdownServerConnections() https://searchfox.org/mozilla-central/rev/49204d3e4b03513ca2741404b7453245863d380c/ipc/glue/UtilityProcessChild.cpp#129 then the process name appears correctly. Without GetCurrentProcess() call.

Comment 4

[:gerard-majax]

Attachment: Bug 1770241 - Enable Utility AudioDecoder for OpenBSD r?gaston!

Comment 5

[:gerard-majax]

On this try: https://treeherder.mozilla.org/jobs?repo=try&revision=78e26d2a0d02d937a01bc4741b3e1837d3dc309d

• 50 retries
• three repro of the leak symptom of the hang

On this try: https://treeherder.mozilla.org/jobs?repo=try&revision=b51b4ec5ad2b99a76a57ef66138b4a8ccea5b64c

• 50 retries
• no repro of the leak

Comment 6

[:gerard-majax]

Attachment: Bug 1770241 - Move SetThisProcessName() to avoid risky GetCurrentProcess() r?haik!

Comment 7

[:gerard-majax]

https://treeherder.mozilla.org/jobs?repo=try&revision=48afd91db756ae6dc4730887a7cc5a3ef6ec9411

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0d8c007c8a7
Move SetThisProcessName() to avoid risky GetCurrentProcess() r=haik

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f0d8c007c8a7