1770363 - Allow the browser toolbox to enable/disable multiprocess behavior on-demand

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

This would allow the user to better focus on only the main process if they don't debug anything from the content processes.
This sounds like a workaround for performance reason, but associated with some other similar filtering, this would allows the user to better focus on exactly what they are debugging.
A simple first approach would add yet another toggle alongside "show content process message" and "enable network request listening".
But ideally we would revamp the iframe dropdown to be a control panel allowing to focus on a particular part of the browser. This would make the browser toolbox much faster by inspecting less resources and also more readable by showing less content and show the content the user cares about.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1770363 - [devtools] Implement on-demand multiprocess debugging in TargetCommand API.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox.

This introduces a checkbox in the iframe dropdown to enable/disable multiprocess debugging live.
Switching between:

• debugging only the main process (all documents, workers and priviledged JS)
• debugging all the processes (same, for each process, we will debug documents, workers, JS, ...)

This helps significantly speed up the browser toolbox when debugging only parent process resources,
while still allowing to switch to debug everything when required.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1770363 - [devtools] Toggle multiprocess mode from the evaluation context selector.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1770363 - [devtools] Better support live multiprocess mode in the inspector.

WIP.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1770363 - [devtools] Fix iframe dropdown on target destruction from the MBT

This only fail on MBT because it still uses non-EFT
and the top level document is displayed in the iframe dropdown
via the old "listFrames/frameUpdate" codepath.
So that its frameData's id isn't related to a target actor
but rather to a frame of the parent-process/window-global target actor...

I'm adding test coverage for the regular web toolbox,
but the fix only reproduce in the context of the browser toolbox.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1770363 - [devtools] Allow to pass any JSON value to ToolboxTask.spawn.

When passing an array, only booleans and number were accepted.
Also arrays were stringified to list of value coma separated,
as if arrays were refering to list of arguments.
That while passing a primitive value would be passed as a unique argument.

Clarify this by explicitely accepting arrays refering as list of argument,
or a primitive value being a unique argument.

I'm also fixing an issue with exceptions not being correctly reported.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1770363 - [devtools] Cover browser toolbox scope feature with a test around the iframe dropdown.

This add some minimal test coverage for the UI bits.

But more detailed test should rather be done around the TargetCommand API (browser_target_command_scope_flag.js).

Comment 8

[Phabricator Automation]

Comment on attachment 9280074 [details]
Bug 1770363 - [devtools] Toggle multiprocess mode from the evaluation context selector.

Revision D148528 was moved to bug 1774646. Setting attachment 9280074 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cdcd2318a9f
[devtools] Implement on-demand multiprocess debugging in TargetCommand API. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/18a6433fd24a
[devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/27e78762006f
[devtools] Allow to pass any JSON value to ToolboxTask.spawn. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a91879be9b4a
[devtools] Cover browser toolbox scope feature with a test around the iframe dropdown. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d29f5041fd98
[devtools] Fix iframe dropdown on target destruction from the MBT r=nchevobbe

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on browser_ext_addon_debugging_netmonitor.js

Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_addon_debugging_netmonitor.js | leaked 3 window(s) until shutdown [url = about:blank]

Comment 11

[Alexandre Poirot [:ochameau]]

Forgot to run the browser/ test.
New try run for this folder:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9ea39c70b8d4cb25e7fc3525d3d1b1a0399718d

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c409831fd65
[devtools] Implement on-demand multiprocess debugging in TargetCommand API. r=nchevobbe,rpl
https://hg.mozilla.org/integration/autoland/rev/d3db0ae3be2e
[devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/de1150e010e7
[devtools] Allow to pass any JSON value to ToolboxTask.spawn. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f064334afbb9
[devtools] Cover browser toolbox scope feature with a test around the iframe dropdown. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0c6d39a1c5d1
[devtools] Fix iframe dropdown on target destruction from the MBT r=nchevobbe

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c409831fd65
https://hg.mozilla.org/mozilla-central/rev/d3db0ae3be2e
https://hg.mozilla.org/mozilla-central/rev/de1150e010e7
https://hg.mozilla.org/mozilla-central/rev/f064334afbb9
https://hg.mozilla.org/mozilla-central/rev/0c6d39a1c5d1