1770442 - Fix t/critic.t to not just look in scripts directory for violations

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Continous Integration, enhancement)

Description

[David Lawrence [:dkl]]

Currently t/critic.pl, when Test::Perl::Critic::Progressive::progressive_critic_ok() is called without arguments, it only looks for code in blib/ directory. If the blib/ directory does not exist, then it tries the lib/, bin/, script/, and scripts/ directory. So in the case of BMO, only the scripts/ directory is scanned which makes the number of actual violations quite low. If we add in the proper files that need to be checked from all code in BMO, then the violations are around 12k.

This bug is to 1) Fix the test to look at all files, and 2) figure out what can be fixed relatively easy and which violations will just go into a new perlcritichistory file to be fixed at a later date.

Comment 1

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 2

[David Lawrence [:dkl]]

Merged to master.
https://github.com/mozilla-bteam/bmo/commit/7191fdb7dabbd21f977b540fd26452bbf2b80fd0