Closed Bug 1770461 Opened 3 months ago Closed 1 month ago

Add support for "awaitPromise" argument for "script.evaluate"

Categories

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

enhancement
Points:
5

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [webdriver:m4], [wptsync upstream])

Attachments

(2 files, 3 obsolete files)

With bug 1742979 we will get basic support for script.evaluate. This bug covers the addition of the awaitPromise argument, and the creation of appropriate webdriver and maybe xpcshell tests.

Blocks: 1770487
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Attachment #9282383 - Attachment is obsolete: true

Depends on D149924

This was originally in D149924, but this changeset might conflict with an upstream PR.
If the PR has not been synced yet when this is ready to land we can either decide to duplicate the tests as mozilla specific tests, or just to leave-open the bug and
land this patch afterwards.

Blocked on the sync from 1776410

Depends on: 1776410

The sync from https://bugzilla.mozilla.org/show_bug.cgi?id=1776410 seems currently blocked, so splitting out this to another patch

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34683 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m4] → [webdriver:m4], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Upstream PR merged by moz-wptsync-bot
No longer depends on: 1776410
Blocks: 1777936

Comment on attachment 9283957 [details]
Bug 1770461 - [bidi] script.evaluate awaitPromise should be mandatory

Revision D150920 was moved to bug 1777936. Setting attachment 9283957 [details] to obsolete.

Attachment #9283957 - Attachment is obsolete: true
Attachment #9283196 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.