1770461 - Add support for "awaitPromise" argument for "script.evaluate"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With bug 1742979 we will get basic support for script.evaluate. This bug covers the addition of the awaitPromise argument, and the creation of appropriate webdriver and maybe xpcshell tests.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770461 - [bidi] Add support for awaitPromise to script.evaluate

Depends on D149411

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770461 - [wdspec] Test various return values for script.evaluate awaitPromise

Depends on D149412

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770461 - [wdspec] Update bidi script tests with mandatory awaitPromise argument

Update the tests per the spec changes from https://github.com/w3c/webdriver-bidi/pull/239

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770461 - [wdspec] Move BiDi awaitPromise tests from evaluate.py to await_promise.py

Depends on D149924

This was originally in D149924, but this changeset might conflict with an upstream PR.
If the PR has not been synced yet when this is ready to land we can either decide to duplicate the tests as mozilla specific tests, or just to leave-open the bug and
land this patch afterwards.

Comment 5

[Julian Descottes [:jdescottes]]

Blocked on the sync from 1776410

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770461 - [bidi] script.evaluate awaitPromise should be mandatory

The sync from https://bugzilla.mozilla.org/show_bug.cgi?id=1776410 seems currently blocked, so splitting out this to another patch

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34683 for changes under testing/web-platform/tests

Comment 8

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/da29b7f8b024
https://hg.mozilla.org/mozilla-central/rev/5ba34c75f73f

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Phabricator Automation]

Comment on attachment 9283957 [details]
Bug 1770461 - [bidi] script.evaluate awaitPromise should be mandatory

Revision D150920 was moved to bug 1777936. Setting attachment 9283957 [details] to obsolete.