Closed Bug 1770483 Opened 2 months ago Closed 1 month ago

Telemetry for some types of autofill is no longer correctly handled

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
3

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox100 --- unaffected
firefox101 --- unaffected
firefox102 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [snt-triaged])

Attachments

(2 files, 2 obsolete files)

Bug 1597791 deprecated the urlbar.picked.autofill scalar in favor of three new scalars, but there are a few other types of autofill results we forgot about:

  • about pages (UrlbarProviderAutofill)
  • Search engine domains (UrlbarProviderAutofill) [1]
  • Preloaded top sites (UrlbarProviderPreloadedSites)
  • Token alias engines (UrlbarProviderTokenAliasEngines) [1]

For example, if you autofill "about:config" and press enter, a couple of errors will be logged:

urlbar.picked.autofill_undefined - Unknown scalar.
Unsupported telemetry type autofill_undefined

We could add a general autofill_other fallback, but we should probably add individual types/scalars for all these.

[1] Edit: Actually search engine domain autofill and token alias engine autofill are not currently reported as autofill in telemetry. That's because those results aren't URL results, and only URL results can be reported as autofill. That logic goes back a ways and I don't want to litigate it now, so I'll drop these two from this bug.

Attached file data-request.md (obsolete) —

Data review request for 4 new keyed scalars related to urlbar autofill

Attachment #9277532 - Flags: data-review?(chutten)

Set release status flags based on info from the regressing bug 1597791

Attached file data-request.md v2 (obsolete) —

Updated data review request for 5 new keyed scalars related to urlbar autofill

Attachment #9277532 - Attachment is obsolete: true
Attachment #9277532 - Flags: data-review?(chutten)
Attachment #9277535 - Flags: data-review?(chutten)

This adds three new keyed scalars similar to the other urlbar.picked.*
scalars:

  • urlbar.picked.autofill_about - For about-page autofill like "about:config"
  • urlbar.picked.autofill_preloaded - For preloaded top sites, but this feature
    is currently disabled
  • urlbar.picked.autofill_other - A fallback for when we forget to set
    result.autofill.type. If we see this in the data, we should investigate and
    fix it. This is similar to the urlbar.searchmode.other fallback keyed
    scalar.

There are two other kinds of autofill, engine domain names (provided by
UrlbarProviderAutofill) and token alias engines (e.g., "@google", provided by
UrlbarProviderTokenAliasEngines), but these two types are not reported as
autofill in telemetry. That's because those results aren't URL results, and
only URL results are reported as autofill.
So I didn't add scalars for these. I also didn't set result.autofill.type for
them because I think we should be deliberate about recording them in
telemetry.

I created a new browser_urlbar_telemetry_autofill.js test and cp'ed it from
browser_urlbar_telemetry_places.js so that blame for the adaptive history task
is preserved.

Attached file data-request.md v3

Updated data review request for 3 new keyed scalars related to urlbar autofill (sorry for the churn!)

Attachment #9277535 - Attachment is obsolete: true
Attachment #9277535 - Flags: data-review?(chutten)

Comment on attachment 9277598 [details]
data-request.md v3

Updated data review request for 3 new keyed scalars related to urlbar autofill (sorry for the churn!)

Attachment #9277598 - Flags: data-review?(chutten)
Has Regression Range: --- → yes

Comment on attachment 9277598 [details]
data-request.md v3

Grabbing this one, as Canadians are out today

Attachment #9277598 - Flags: data-review?(chutten) → data-review?(jhirsch)

Comment on attachment 9277598 [details]
data-request.md v3

data-review-+

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, using the usual desktop telemetry system.

  1. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, using the usual desktop opt-out in about:preferences.

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes. :adw will monitor.

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

  1. Is the data collection request for default-on or default-off?

Default-on.

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes.

  1. Does the data collection use a third-party collection tool?

No.

Attachment #9277598 - Flags: data-review?(jhirsch) → data-review+
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08e8656f257c
Properly record telemetry for urlbar autofill results that aren't currently handled. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.