1770616 - Update color-mix() to match latest spec.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1770616 - Update color-mix() syntax to match the current spec. r=#style,#layout-reviewers,barret

Test expectation updates for this in the latest patch of the bug.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1770616 - Make the color interpolation code more generic. r=#style,#layout-reviewers,barret

It's really piece-wise premultiplied interpolation, with a special-case
for hue, so centralize the implementation.

Depends on D147002

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1770616 - Implement more color-mix() color-spaces. r=#style,#layout-reviewers,barret

We had code to convert between these and the latest draft supports them so...

Depends on D147003

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1770616 - Fix color-mix() percentage normalization. r=#style,#layout-reviewers,barret

Depends on D147004

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1770616 - Fix hue adjustment to match the spec. r=#style,#layout-reviewers,barret

The value to sum is tau, not pi. This was caught by some tests.

Depends on D147005

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1770616 - Do hue interpolations in degrees rather than radians. r=#style,#layout-reviewers,barret

This gives us a bit more precision.

Depends on D147006

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1770616 - Update test expectations. r=#style,#layout-reviewers,barret

I made sure the new fixes are covered. There are still a bunch of failures.

Those can be explained by:

• https://github.com/web-platform-tests/wpt/issues/34158 (tests expecting color-mix() to go away at parse time)
• Off-by-one in the color channels (so float precision errors).
• Unimplemented features like the color() function.

Depends on D147007

Comment 8

[chris]

Off-by-one in the color channels (so float precision errors).

Or perhaps, truncation rather than rounding?

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: WIP: Bug 1770616 - Comment fix

Depends on D147005

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a60b403f434b
Update color-mix() syntax to match the current spec. r=barret
https://hg.mozilla.org/integration/autoland/rev/aa3f28383e07
Make the color interpolation code more generic. r=barret
https://hg.mozilla.org/integration/autoland/rev/be40d47e2ecf
Implement more color-mix() color-spaces. r=barret
https://hg.mozilla.org/integration/autoland/rev/9e47db20f60a
Fix color-mix() percentage normalization. r=barret
https://hg.mozilla.org/integration/autoland/rev/64a379b5096c
Fix hue adjustment to match the spec. r=barret
https://hg.mozilla.org/integration/autoland/rev/6b1a2fbdb7b7
Do hue interpolations in degrees rather than radians. r=barret
https://hg.mozilla.org/integration/autoland/rev/60c4d08d09f0
Update test expectations. r=barret

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a60b403f434b
https://hg.mozilla.org/mozilla-central/rev/aa3f28383e07
https://hg.mozilla.org/mozilla-central/rev/be40d47e2ecf
https://hg.mozilla.org/mozilla-central/rev/9e47db20f60a
https://hg.mozilla.org/mozilla-central/rev/64a379b5096c
https://hg.mozilla.org/mozilla-central/rev/6b1a2fbdb7b7
https://hg.mozilla.org/mozilla-central/rev/60c4d08d09f0