1770634 - Perma SM wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=378895538&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/blLrBfv-QUyFqHMJN0hAFw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-05-22T09:21:45.678Z] ## wasm/jsapi/global/constructor.any.js: rc = 0, run time = 0.224109
[task 2022-05-22T09:21:45.678Z] 
[task 2022-05-22T09:21:45.678Z] Harness status: OK (Reported by harness: None)
[task 2022-05-22T09:21:45.678Z] Subtest "name": as expected: PASS
[task 2022-05-22T09:21:45.678Z] Subtest "length": as expected: PASS
[task 2022-05-22T09:21:45.678Z] Subtest "No arguments": as expected: PASS
[task 2022-05-22T09:21:45.678Z] Subtest "Calling": as expected: PASS
[task 2022-05-22T09:21:45.678Z] Subtest "Order of evaluation": as expected: PASS
[task 2022-05-22T09:21:45.678Z] Subtest "Invalid descriptor argument": as expected: PASS
[task 2022-05-22T09:21:45.678Z] Subtest "Invalid type argument": as expected: PASS
[task 2022-05-22T09:21:45.678Z] Subtest "Construct v128 global": expected FAIL, found PASS
[task 2022-05-22T09:21:45.679Z] Subtest "i64 with default": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Default value for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value undefined for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value null for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value true for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value false for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value 2 for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value "3" for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value object with toString returning string for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value object with valueOf returning string for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value object with toString returning number for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value object with valueOf returning number for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "BigInt value for type i32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Default value for type f32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value undefined for type f32": as expected: PASS
[task 2022-05-22T09:21:45.679Z] Subtest "Explicit value null for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value true for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value false for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value 2 for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value "3" for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value object with toString returning string for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value object with valueOf returning string for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value object with toString returning number for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value object with valueOf returning number for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "BigInt value for type f32": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Default value for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value undefined for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value null for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value true for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value false for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value 2 for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value "3" for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value object with toString returning string for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value object with valueOf returning string for type f64": as expected: PASS
[task 2022-05-22T09:21:45.680Z] Subtest "Explicit value object with toString returning number for type f64": as expected: PASS
[task 2022-05-22T09:21:45.681Z] Subtest "Explicit value object with valueOf returning number for type f64": as expected: PASS
[task 2022-05-22T09:21:45.681Z] Subtest "BigInt value for type f64": as expected: PASS
[task 2022-05-22T09:21:45.681Z] Subtest "Explicit value undefined for type i64": as expected: PASS
[task 2022-05-22T09:21:45.681Z] Subtest "Explicit value true for type i64": as expected: PASS
[task 2022-05-22T09:21:45.681Z] Subtest "Explicit value false for type i64": as expected: PASS
[task 2022-05-22T09:21:45.681Z] Subtest "Explicit value "3" for type i64": as expected: PASS
[task 2022-05-22T09:21:45.682Z] Subtest "Explicit value bigint "123" for type i64": as expected: PASS
[task 2022-05-22T09:21:45.682Z] Subtest "Explicit value object with toString returning string for type i64": as expected: PASS
[task 2022-05-22T09:21:45.683Z] Subtest "Explicit value object with valueOf returning string for type i64": as expected: PASS
[task 2022-05-22T09:21:45.683Z] Subtest "Explicit value object with toString returning bigint for type i64": as expected: PASS
[task 2022-05-22T09:21:45.684Z] Subtest "Explicit value object with valueOf returning bigint for type i64": as expected: PASS
[task 2022-05-22T09:21:45.685Z] Subtest "Pass non-bigint as i64 Global value: null": as expected: PASS
[task 2022-05-22T09:21:45.686Z] Subtest "Pass non-bigint as i64 Global value: 666": as expected: PASS
[task 2022-05-22T09:21:45.687Z] Subtest "Pass non-bigint as i64 Global value: object "5"": as expected: PASS
[task 2022-05-22T09:21:45.688Z] Subtest "Pass non-bigint as i64 Global value: object "[object Object]"": as expected: PASS
[task 2022-05-22T09:21:45.688Z] Subtest "Pass non-bigint as i64 Global value: symbol "Symbol()"": as expected: PASS
[task 2022-05-22T09:21:45.688Z] Subtest "Stray argument": as expected: PASS
[task 2022-05-22T09:21:45.688Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.688Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.688Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-UNEXPECTED-FAIL | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]
[task 2022-05-22T09:21:45.689Z] TEST-PASS | wasm/jsapi/global/constructor.any.js | (args: "") [0.2 s]

Comment 1

[James Graham [:jgraham]]

If this is implemented everywhere the patch is something like

iff --git a/testing/web-platform/meta/wasm/jsapi/global/constructor.any.js.ini b/testing/web-platform/meta/wasm/jsapi/global/constructor.any.js.ini
index 07322f7322859..c115137aa990b 100644
--- a/testing/web-platform/meta/wasm/jsapi/global/constructor.any.js.ini
+++ b/testing/web-platform/meta/wasm/jsapi/global/constructor.any.js.ini
@@ -6,8 +6,3 @@
 [constructor.any.html]
   [Construct v128 global]
     expected: FAIL
-
-
-[constructor.any.js]
-  [Construct v128 global]
-    expected: FAIL

If it's platform-specific then the expected value needs to be conditional in some way.

Comment 2

[Intermittent Failures Robot]

2 failures in 2694 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform and build breakdown:

• linux32: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1770634&startday=2022-05-16&endday=2022-05-22&tree=all

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1769536

Comment 4

[Jan de Mooij [:jandem]]

This is probably because we don't support SIMD on arm32? Would be good to fix this perma-failure soon...

Comment 5

[Ryan Hunt [:rhunt] (on leave until early May)]

The WPT test here is correct wrt to the spec, so we should be passing it. We only pass it on ARM32 with SIMD disabled, but with the test expectations that leads to an unexpected failure.

Comment 6

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1770634 - wasm: Report TypeError when constructing global with v128. r?jseward

The JS-API for global constructor [1] has a step for throwing
a TypeError when type is v128. We previously would just throw
a TypeError if a default value was provided and type was v128.

Two unused error messages are removed, and a comment for clarity
on the error handling of ToValType is added.

[1] https://webassembly.github.io/spec/js-api/index.html#globals

Comment 7

[Intermittent Failures Robot]

19 failures in 631 pushes (0.03 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 14
• mozilla-central: 5

Platform and build breakdown:

• linux32: 19
  • debug: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1770634&startday=2022-05-24&endday=2022-05-24&tree=all

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c44428c0eca
wasm: Report TypeError when constructing global with v128. r=jseward

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6c44428c0eca

Comment 10

[Intermittent Failures Robot]

40 failures in 2624 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #21 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 30
• mozilla-central: 10

Platform and build breakdown:

• linux32: 40
  • debug: 40

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1770634&startday=2022-05-23&endday=2022-05-29&tree=all