1770688 - Move some common testing functions to jit-test/lib/wasm.js

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

A number of testing helpers - most notably iota - are duplicated in numerous wasm test files. Move these helpers to wasm.lib.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1770688 - Move common testing functions to lib/wasm.js. r?jseward

Move a number of Array-oriented testing functions to lib/wasm.js, as we
keep copying them from file to file, with variations.

The main sticking point here was actually that the simd tests include
a common testing file using an include: directive, but this directive
is processed before the common include: directive that loads wasm.js.

Unfortunately the present patch creates a dependency wherein the simd
common testing file will depend on wasm.js being loaded first.

To fix the dependency order the simd tests were updated to load the
common testing file explicitly, and this load will happen after
wasm.js is loaded.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/280a33091659
Move common testing functions to lib/wasm.js. r=jseward

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/280a33091659