Closed Bug 1770754 Opened 2 years ago Closed 1 year ago

Support serialization of complex objects with container value fields

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
8

Tracking

(firefox107 fixed)

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [webdriver:m5], [wptsync upstream])

Attachments

(3 files, 2 obsolete files)

Bug 1770754 - [bidi] Add internal ids to the duplicated objects for a given serialization.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1770754 - [bidi] Support serialization of complex objects with container value fields.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1770754 - [wdspec] Add tests for internal ids.
48 bytes, text/x-phabricator-request
Details | Review

With this bug we want to extend our serialization for types that have a container type in their value field. This means adding support for the max depth argument.

Note that this is not about using the strong handle field which is bug 1770736.

No longer depends on: 1770751
Blocks: 1770794
Summary: Support serialization of complex objects with container value fields → Add webdriver tests for "script.evaluate' for returning complex objects with container value fields
No longer blocks: 1770794
Summary: Add webdriver tests for "script.evaluate' for returning complex objects with container value fields → Support serialization of complex objects with container value fields
Blocks: 1770794
No longer blocks: 1770794
Blocks: 1770794
Blocks: 1770799
Blocks: 1731589
Depends on: 1779066

In the scope of this bug, we also should remove the if condition introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1779226

Depends on D155446

This is missing tests, and might need to move to Bug 1770754, but since I brought it up when looking at supporting handle, I wanted to experiment with the
implementation.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Status: ASSIGNED → NEW
Priority: P1 → P2
Whiteboard: [webdriver:m4] → [webdriver:backlog]
No longer blocks: 1770420
Blocks: 1790361
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m5]
Assignee: jdescottes → aborovova
Status: NEW → ASSIGNED
Attachment #9291635 - Attachment is obsolete: true
Attachment #9291634 - Attachment is obsolete: true
See Also: → 1791715

Depends on D157634

See Also: → 1792149
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2faeb47919ce
[bidi] Add internal ids to the duplicated objects for a given serialization. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/1fa586b566a7
[wdspec] Add tests for internal ids. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/a8c3d932b570
[bidi] Support serialization of complex objects with container value fields. r=webdriver-reviewers,jdescottes,whimboo

https://hg.mozilla.org/mozilla-central/rev/2faeb47919ce
https://hg.mozilla.org/mozilla-central/rev/1fa586b566a7
https://hg.mozilla.org/mozilla-central/rev/a8c3d932b570

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

James, can you please check why no upstream PR for the second patch has been created? Thanks!

Flags: needinfo?(james)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36181 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m5] → [webdriver:m5], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(james)
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.