1770754 - Support serialization of complex objects with container value fields

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With this bug we want to extend our serialization for types that have a container type in their value field. This means adding support for the max depth argument.

Note that this is not about using the strong handle field which is bug 1770736.

Comment 1

[Alexandra Borovova [:Sasha]]

In the scope of this bug, we also should remove the if condition introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1779226

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770754 - [bidi] Set internal ids if needed during complex object serialization

Depends on D155446

This is missing tests, and might need to move to Bug 1770754, but since I brought it up when looking at supporting handle, I wanted to experiment with the
implementation.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770754 - [bidi] Check if complex object is a known object in serialization

Depends on D155518

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1770754 - [bidi] Add internal ids to the duplicated objects for a given serialization.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1770754 - [bidi] Support serialization of complex objects with container value fields.

Depends on D157634

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1770754 - [wdspec] Add tests for internal ids.

Depends on D157634

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2faeb47919ce
[bidi] Add internal ids to the duplicated objects for a given serialization. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/1fa586b566a7
[wdspec] Add tests for internal ids. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/a8c3d932b570
[bidi] Support serialization of complex objects with container value fields. r=webdriver-reviewers,jdescottes,whimboo

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2faeb47919ce
https://hg.mozilla.org/mozilla-central/rev/1fa586b566a7
https://hg.mozilla.org/mozilla-central/rev/a8c3d932b570

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

James, can you please check why no upstream PR for the second patch has been created? Thanks!

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36181 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot