Closed Bug 1770771 Opened 3 years ago Closed 3 years ago

Convert animated pngs to static before storing them as favicons

Categories

(Toolkit :: Places, defect, P3)

defect

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: mak, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Keywords: papercut, perf, Whiteboard: [snt-scrubbed][places-papercut])

Attachments

(1 file)

It looks like we're just storing pngs as they are, but they may include animated frames. We should detect those cases and convert to static images.
An example is the favicon of about:robots.

Whiteboard: [snt-triaged][places-papercut]

Will this apply only to the favicons for bookmarks, or also to favicons displayed in tabs?

Blocks: power-usage
Whiteboard: [snt-triaged][places-papercut] → [snt-scrubbed][places-papercut]
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Attachment #9293860 - Attachment description: Bug 1770771: Store only first frame data as favicon data. → Bug 1770771: Store only first frame data if animated favicon.
See Also: → 1766284
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cedcd94b76b2 Store only first frame data if animated favicon. r=mak
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: