1770789 - Drag and drop bookmarks makes firefox crash. nsNavHistory::ResultsAsList() takes too long.

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[Andrea Vai]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

I was organizing my (many) bookmarks of my bookmarks bar by dragging and dropping one of them in a preexistent folder

Actual results:

Firefox crashed before I was able to drop the bookmark (when it crashed, I hadn't released the mouse button yet). Other times Firefox freezed for many seconds.

Expected results:

The bookmark I was moving should have been placed in the destination folder.

FF 100 on Fedora 35.
I can provide a crash ID if needed (many crash IDs, if needed :-) )

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak]]

suspect this may be similar to bug 1746812, or even the same thing.

It would be useful to have additional information about your system, like which compositor do you use?
And yes, it would also be useful to get the crash ids from about:crashes.

Comment 3

[Andrea Vai]

I don't know which compositor I use, how can I find it?

I was trying to obtain a new crash id, but at the moment I am not able to reproduce the crash because as I try to drag one item out from a folder, it simply disappears under the mouse pointer. So, it seems a new bug. What can I do better to help here?

Comment 4

[Marco Bonardo [:mak]]

From a quick search you can use inxi -Gxx | grep compositor, I suspect we also report that information in the about:support page (but I'm not 100% sure)., so you can copy the text from that page and then use the Attach New File button above here to attach that .txt file.

Comment 5

[Andrea Vai]

thanks, so it is:

$ inxi -Gxx | grep compositor
compositor: gnome-shell v: 41.6 driver: X: loaded: modesetting

Comment 6

[Marco Bonardo [:mak]]

Ok, it sounds like it may not be the same as bug 1746812, then.

Do you have any crash ids in about:crashes that you could share with us? That page collects previous crashes so even if you can't reproduce the bug now, it could have stored some recent crashes.

Comment 7

[Andrea Vai]

Well, I was trying to reproduce the bug to be sure I didn't send a crash occurred in other ways.
Anyway, this is right the one that made me file this bug report: 18f0080e-6129-4ad7-ab9b-158b00220523

Comment 8

[Marco Bonardo [:mak]]

Hm this is still a crash in wayland https://crash-stats.mozilla.org/report/index/18f0080e-6129-4ad7-ab9b-158b00220523

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Please attach your about:support page.
Also more crash ID.
Can you test latest nightly?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox#Testing_Mozilla_binaries
Thanks.

Comment 11

[Andrea Vai]

Attachment: About:support

Comment 12

[Andrea Vai]

with nightly firefox-103.0a1 and the command

$ MOZ_ENABLE_WAYLAND=1 ./firefox -ProfileManager -no-remote

I reproduced the problem and obtained the two crash IDs:

bp-79112da6-4caa-414d-9b5f-6a6ea0220624
bp-7fcc0e8f-15d5-4a86-92aa-47e590220624

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Thanks.

Do you mind to create a screencast of the issue?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox#Collect_information_for_a_bug_report

It helps me understand how to reproduce it.
Thanks!

Comment 14

[Robbert Gurdeep Singh]

Attachment: screenrecording_22-06-27-102616.mp4

Screencast: dragging a bookmark into the overflow menu crashes Firefox on Sway version 1.7, (wlroots version 0.15.1 on NixOS Linux nixos 5.15.47)

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Robbert, can you try a different compositor? (mutter/kwin)
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox#Testing_different_Wayland_compositor
Thanks.

Comment 16

[Martin Stránský [:stransky] (ni? me)]

For some reason the bookmark management is very slow under Wayland. Works fast under X11.

Comment 17

[Robbert Gurdeep Singh]

I cannot reproduce the failure in mutter, It works fine there.

There is a small UX problem that causes the dragging of bookmarks from the overflow panel to the bookmarks bar cancels if you are not very fast.

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Seems to be caused by wrong bookmark management performance. Profile https://share.firefox.dev/3HWoSDn
We're running the JS events from Gtk events and that block whole browser which crashes then.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

It's the same under X11.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 21

[Mark Banner (:standard8)]

We think this would be fixed by the work required for bug 490714 - that would take a lot of the work outside the stack.

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.