Picture in picture keyboard shortcut seek time should be customizable
Categories
(Toolkit :: Picture-in-Picture, enhancement, P2)
Tracking
()
People
(Reporter: asafko, Unassigned)
References
Details
+++ This bug was initially created as a clone of Bug #1693961 +++
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:85.0) Gecko/20100101 Firefox/85.0
Steps to reproduce:
Open picture in picture mode of video. Press keyboard shortcuts (← or →) to seek forward or backward.
Actual results:
15 seconds of time are skipped each time.
Expected results:
The amount of time skipped should be customizable in the firefox preferences.
For clarity, the current time is currently hard coded as 5 seconds, rather than 15 seconds (searchfox). Number of seconds skipped really depends on the video player currently in use (ex. Netflix will likely remain with 10 seconds seek time for a better user experience).
Setting severity to N/A since this is technically an enhancement ticket rather than a defect.
|
||
Comment 2•3 years ago
|
||
(In reply to kpatenio from comment #1)
Number of seconds skipped really depends on the video player currently in use (ex. Netflix will likely remain with 10 seconds seek time for a better user experience).
Do you mean for the PiP controls?
(In reply to Shane Hughes [:aminomancer] from comment #2)
(In reply to kpatenio from comment #1)
Number of seconds skipped really depends on the video player currently in use (ex. Netflix will likely remain with 10 seconds seek time for a better user experience).
Do you mean for the PiP controls?
Hi apologies for the late reply - this somehow fell off my radar for quite a while. I'll clarify a bit: while we can try to adjust the seek time ourselves, it may not always work as expected for certain sites. For instance, Netflix automatically determines how many seconds backwards or forwards to go. Setting some arbitrary time like 15 seconds may not affect the seek time at all or may not work as intended while watching a Netflix video in PiP. So this is something that we should keep in mind. And as for "video players", I meant the video players that sites may use to display videos (ex. shaka player, videojs, jw player, etc.).
|
|
||
Comment 4•3 years ago
|
||
(In reply to kpatenio from comment #3)
Hi apologies for the late reply - this somehow fell off my radar for quite a while. I'll clarify a bit: while we can try to adjust the seek time ourselves, it may not always work as expected for certain sites. For instance, Netflix automatically determines how many seconds backwards or forwards to go. Setting some arbitrary time like 15 seconds may not affect the seek time at all or may not work as intended while watching a Netflix video in PiP. So this is something that we should keep in mind. And as for "video players", I meant the video players that sites may use to display videos (ex. shaka player, videojs, jw player, etc.).
That makes sense to me. It looks like you already implemented that for netflix? I got the impression that it will be very hard to dynamically retrieve a seek time from the video player. If we had made the basic seek time an API-settable property then I guess those video player libraries might have used it, but at this point they all have their own quirky ways of seeking that really complicates things. But it seems like many contributors are already hard at work on making site-specific video wrappers, so perhaps that's good enough.
Description
•