1770870 - Exclude history URLs with the AMP query parameter from appearing in urlbar results

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

We want to exclude history URLs with the AMP query parameter from appearing in the urlbar results. This bug is the urlbar version of bug 1768529, which implemented similar logic for top sites tiles.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1770870 - Exclude history URLs with the AMP query parameter from appearing in urlbar results.

This modifies the muxer to discard history results whose URLs were originally
sponsored according to the same URL search param we used for top sites in
bug 1768529. I used the newtab pref from that bug. I thought about making a
urlbar-specific version, but there's no reason to complicate it.

The test is very similar to the test I added for the other bug.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d676776907fccee273dc659e9dca4e46f689715a

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab2309dc14c2
Exclude history URLs with the AMP query parameter from appearing in urlbar results. r=daisuke,nanj

Comment 4

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]:

This is very similar to bug 1768533, which we recently uplifted to RC2. This bug applies to the urlbar, while the other bug applied to new tab tiles. In both cases we are hiding previously sponsored URLs that are in the user's history. There is little impact on Firefox users, rather it's a feature request from our partner of sponsored tiles/suggestions. If declined, Firefox would show previous sponsored tiles as organic tiles which could de-value the sponsored tiles/suggestions for both our partner and Mozilla.

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9278287 [details]
Bug 1770870 - Exclude history URLs with the AMP query parameter from appearing in urlbar results.

Beta/Release Uplift Approval Request

• User impact if declined: This is very similar to bug 1768533, which we recently uplifted to RC2. This bug applies to the urlbar, while the other bug applied to new tab tiles. In both cases we are hiding previously sponsored URLs that are in the user's history. There is little impact on Firefox users, rather it's a feature request from our partner of sponsored tiles/suggestions. If declined, Firefox would show previous sponsored tiles as organic tiles which could de-value the sponsored tiles/suggestions for both our partner and Mozilla.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: I'll add a separate comment with STR.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch with very little impact to Firefox users, only hides some sponsored URLs they might otherwise see. Only impacts users in the U.S., where Firefox Suggest is enabled. Doesn't impact other users.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Drew Willcoxon :adw]

STR for QA

1. Type example.com/?mfadid=adm in the urlbar and press enter
2. Repeat the previous step 2 more times. You can use the same tab.
3. Open a new tab and close the old one
4. Type ample in the urlbar and verify the URL from step 1 does not appear in the results
5. Type example.com (without anything else at the end) in the urlbar and press enter. If you do this on a new profile, it will autofill as you type it.
6. Open a new tab and close the old one
7. Type ample in the urlbar and verify http://example.com (without anything else at the end) appears in the results. It should not be the exact same URL from step 1
8. Click the http://example.com result
9. Verify example.com (without anything else at the end) loads

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9278287 [details]
Bug 1770870 - Exclude history URLs with the AMP query parameter from appearing in urlbar results.

Approved for 101.0rc2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/05536792c10e

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ab2309dc14c2

Comment 10

[Cosmin Muntean [:cmuntean], Ecosystem QA]

We have verified this issue on the latest Nightly 92.0a1 build (Build ID: 20220526203855) and Firefox 101.0 RC2 build (Build ID: 20220525210143) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04.

• In order to verify this issue we have used the STR described on comment 6. During testing, we haven't found any new issues.

We will retest this issue as soon as adM will also add the parameter in the quicksuggest results.