1770874 - Clean up focus/blur handling code of editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 1: Make some clean ups around `EditorBase::OnFocus` r=m_kato!

Depends on D147136

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 2: Move the lambda in `EditorEventListener::Focus` to `EditorBase` r=m_kato!

It's currently a public method, but it can be protected in a following patch.

Depends on D147137

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 3: Move `EditorEventListener::SpellCheckIfNeeded` to `EditorBase` r=m_kato!

This method also can be protected in a following patch.

Depends on D147138

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 4: Move most part of `EditorEventListener::Focus` into `EditorBase::OnFocus` r=m_kato!

Depends on D147139

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 5: Move `EditorBase::ReinitializeSelection` into `TextEditor` r=m_kato!

Depends on D147140

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 6: Move most part of `EditorEventListener::Blur` into `EditorBase` r=m_kato!

Note that EditorBase::OnBlur will be simpler at the last patch.

Depends on D147141

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 7: Make `EditorBase::OnFocus` temporarily a virtual method r=m_kato!

I'd like to split it for TextEditor and HTMLEditor. HTMLEditor does not
require flushing the layout because it's required by TextEditor if and only if
a preceding focus event listener or the Element.focus caller reframes
<input> or <textarea> element (bug 1755104). So this would fix bug 1760045.

Depends on D147142

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770874 - part 8: Make `EditorBase::OnBlur` temporarily a virtual method r=m_kato!

Similar to the previous patch, we should split the method into TextEditor
and HTMLEditor.

Depends on D147143

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6946652d4ed9
part 1: Make some clean ups around `EditorBase::OnFocus` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/77b1aeae51f1
part 2: Move the lambda in `EditorEventListener::Focus` to `EditorBase` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b635369043bd
part 3: Move `EditorEventListener::SpellCheckIfNeeded` to `EditorBase` r=m_kato

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/526ea470c4dd
part 4: Move most part of `EditorEventListener::Focus` into `EditorBase::OnFocus` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/9bb0023ac750
part 5: Move `EditorBase::ReinitializeSelection` into `TextEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/049366a15c3c
part 6: Move most part of `EditorEventListener::Blur` into `EditorBase` r=m_kato

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75a25dbc4c88
part 7: Make `EditorBase::OnFocus` temporarily a virtual method r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5d866154c49f
part 8: Make `EditorBase::OnBlur` temporarily a virtual method r=m_kato

Comment 12

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6946652d4ed9
https://hg.mozilla.org/mozilla-central/rev/77b1aeae51f1
https://hg.mozilla.org/mozilla-central/rev/b635369043bd
https://hg.mozilla.org/mozilla-central/rev/526ea470c4dd
https://hg.mozilla.org/mozilla-central/rev/9bb0023ac750
https://hg.mozilla.org/mozilla-central/rev/049366a15c3c
https://hg.mozilla.org/mozilla-central/rev/75a25dbc4c88
https://hg.mozilla.org/mozilla-central/rev/5d866154c49f

Comment 13

[Pascal Chevrel:pascalc]

Backed out 8 changesets (bug 1770874) on beta, large refactoring during soft code freeze, needs nightly bake time a=backout
https://hg.mozilla.org/releases/mozilla-beta/rev/f4160fb449e4