1770932 - Show profile details in the network throttling menu items

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

In Bug 1770882 we are adding a title to the Menu button which gives details about the selected profile.

We could also surface a less verbose version in the menu items themselves.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: proposal_1_full_text.png

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: proposal_2_with_icons.png

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: proposal_3_with_slash.png

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: proposal_4_no_icon.png

Comment 5

[Julian Descottes [:jdescottes]]

Note that for the version with icons, I think we can also simply omit the icon for the latency. Users will probably be able to guess that it's latency, and this will still be explicitly written in the tooltip of the selected profile.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770932 - [devtools] Show profile details in the network throttling menu items

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thank you for the patch, Julian!

I like the last screenshot (comment #4)

Some comments/ideas:

1. What about using a tab \t between the profile name and details, so the details are rendered as a column. Something like:

GPRS        (50Kbps, 20Kbps, 500ms)
Regular 2G  (250Kbps, 50Kbps, 300ms)
Good 2G     (450Kbps, 150Kbps, 150ms)
...

Not sure how feasible this would be, we'd likely need to calculate the label manually (impact on localization) and the font might be an isssue (using spaces instead of \t). So, this is questinable.

2. What about adding one more Learn More (or Help menu item (+ separator) at the end. It could point to our docs? It would have to be one of the two pages depending on whether the menu is opened in Network monitor or RDM. But, this would allow the user to easily learn about the numbers.

https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode/index.html#network-throttling
https://firefox-source-docs.mozilla.org/devtools-user/network_monitor/throttling/index.html

3. Every context menu item could have a tooltip with more details, e.g. those which are in the first screenshot (comment #1)

Comment 8

[Julian Descottes [:jdescottes]]

Thanks for the feedback, re 3) I agree, it would be great to have a tooltip for each context menu item, but I could not make it work, even when setting the "tooltiptext" attribute correctly on each item. Might need more investigation.

Comment 9

[Hubert Boma Manilla (:bomsy)]

I like the screenshot on Comment 4 as well. Doesn't feel as congested as the others.

What i felt might be confusing was knowing which was download or upload,
but i think in most places download is mostly first before upload,so that should be ok.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11009038ca28
[devtools] Show profile details in the network throttling menu items r=devtools-reviewers,nchevobbe

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/11009038ca28