177099 - Stored queries ordering and editing broken after moving to CGI.pm

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P1)

Description

[Toms Baugis]

As already discussed in irc.mozilla.org:
After moving to CGI.pm, stored queries are something like broken.

Bugzilla Version 2.17
Steps to reproduce(1):
1.1. Click on a stored query
1.2. Click on one of column names to change order

Result - you get buglist of all bugs
Expected - stored query ordered by field

Steps to reproduce(2):
2.1. Click on a stored query
2.2. Click on "Edit this query"
Result - you get default query to edit.
Expected - stored query to edit

Comment 1

[Bradley Baetz (:bbaetz)]

The fix is to replace |my $query| with $::buffer in line 239 on buglist.cgi, and
then creation teh Bugzilla::CGI objkect using that instead

I'm not going to ahve time to manage this for the next few weeks - anyone?

Comment 2

[Dave Miller [:justdave]]

I'll grab it.

Comment 3

[Dave Miller [:justdave]]

Attachment: Patch

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 104367 [details] [diff] [review]
Patch

If this works, r=bbaetz x2

$::buffer will go eventually, but I didn't mean to kill it off yet...

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 104367 [details] [diff] [review]
Patch

removing second-review based on bbaetz's comment #4, where he gave 2xr= on the
condition that it works.  That isn't a review :)

I haven't tested it yet, I just posted the patch bbaetz told me would fix it in
IRC.

I'll try it out later tonight.	I'd appreciate confirmation from Tom if you
back out your previous fix and try this and see if it works.

Comment 6

[Toms Baugis]

i confirm, that patch works and fixes the problem.
so, i would give a 2xr=  (or something)  :)

Comment 7

[Dave Miller [:justdave]]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.205; previous revision: 1.204
done