1771036 - Fix build failure on Aarch64 host

Status: RESOLVED FIXED

(NSS :: Build, enhancement, P5)

Description

[Giulio Benetti]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.64 Safari/537.36

Steps to reproduce:

Build with Makefile on a Mac-Mini M1 Aarch64 processor.

Actual results:

Build fails while linking nsinstall with:
gcc: error: unrecognized command-line option '-m64'

Comment 1

[Giulio Benetti]

Attachment: 0001-Bug-1771036-Fix-build-failure-on-Aarch64-host.patch

Comment 2

[John Schanck [:jschanck]]

Attachment: Bug 1771036 - allow LDFLAGS override in makefile builds. r=#nss-reviewers

Patch provided by Giulio Benetti.

Comment 3

[John Schanck [:jschanck]]

Sounds reasonable to me. Thanks!

Comment 4

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/190801f7f1fb25490098487abacb1fd2ca5ef1e8

Comment 5

[Giulio Benetti]

(In reply to John Schanck from comment #4)

https://hg.mozilla.org/projects/nss/rev/190801f7f1fb25490098487abacb1fd2ca5ef1e8

Hi John,

is there a reason why the authorship of the patch is not mine?
It's only to understand if I've done something wrong while creating the patch.
In the past I've provided 10+ patches this way and hey have been committed with my authorship.

So maybe something changed?

Kind regards

Comment 6

[John Schanck [:jschanck]]

Hi Giulio, it was my mistake---I'm new to phabricator and didn't know the right process. It is slightly easier for us if you submit your patches using moz-phab (https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html), but patch files are fine too.

Comment 7

[Giulio Benetti]

(In reply to John Schanck from comment #6)

Hi Giulio, it was my mistake---I'm new to phabricator and didn't know the right process. It is slightly easier for us if you submit your patches using moz-phab (https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html), but patch files are fine too.

Ok, fine then :-) I still need to fix another build bug:
http://autobuild.buildroot.net/results/68754f6598e09dbd13421bab5abfc4e90a34175c/build-end.log

but I really have few time. Once done I will open a bug and add a patch for it.

Kind regards