1771089 - Add a lint-like task to check rust vendoring

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - WIP

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Properly error out on license errors in mach vendor rust.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Error out with a message when cargo is missing.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Make VendorRust.vendor return a bool rather than hard exit on error.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Fix typo in extra dupes error message.

and clarify we prefer avoiding dupes.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Fail more gracefully when cargo update/vendor fail during mach vendor rust.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Report the vendor_rust.py path relative to topsrcdir.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Add a lint-like task to check rust vendoring.

This is deliberately simple. Future improvements will report if the
vendoring doesn't produce the same content as what's in the tree, and
attach errors to a better location than the first line of Cargo.lock.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59830dcb92f5
Properly error out on license errors in mach vendor rust. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/76b9a861f016
Error out with a message when cargo is missing. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/5a3f7cce34ea
Make VendorRust.vendor return a bool rather than hard exit on error. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/b8f8ff11f6a7
Fix typo in extra dupes error message. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/388adf0ff75c
Fail more gracefully when cargo update/vendor fail during mach vendor rust. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/df197dcfb7f0
Report the vendor_rust.py path relative to topsrcdir. r=firefox-build-system-reviewers,andi

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/59830dcb92f5
https://hg.mozilla.org/mozilla-central/rev/76b9a861f016
https://hg.mozilla.org/mozilla-central/rev/5a3f7cce34ea
https://hg.mozilla.org/mozilla-central/rev/b8f8ff11f6a7
https://hg.mozilla.org/mozilla-central/rev/388adf0ff75c
https://hg.mozilla.org/mozilla-central/rev/df197dcfb7f0

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1771089 - Dummy change

Comment 12

[Phabricator Automation]

Comment on attachment 9279010 [details]
Bug 1771089 - Dummy change

Revision D147809 was moved to bug 1772035. Setting attachment 9279010 [details] to obsolete.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/468cce594b04
Add a lint-like task to check rust vendoring. r=firefox-build-system-reviewers,linter-reviewers,marco,andi

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/468cce594b04

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:glandium, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.