1771099 - Bump glean minimum version to bug 1770791 fix

Status: RESOLVED FIXED

(Conduit :: moz-phab, task)

Description

[Tooru Fujisawa [:arai]]

bug 1770791 hits moz-phab.
Once the fixed version of glean python package is released, the minimum version requirement for glean-sdk in moz-phab should be bumped

Comment 1

[Tooru Fujisawa [:arai]]

glean-sdk==50.0.1 has the fix
https://pypi.org/project/glean-sdk/

Comment 2

[:glob ✱]

Thanks Arai!

Note that over in that bug Jan-Erik said:

I noticed that moz-phab unconditionally uses any v36 or higher of Glean. That seems kinda dangerous, we're known for making breaking changes (and v50 was a big one and I didn't even consider that it will roll out in MozPhab early).

We should probably pin against the major version only.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1771099 - Bump glean-sdk version requirement to 50.0.1 or newer. r?sheehan!

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Tooru, can this land?

Comment 5

[Tooru Fujisawa [:arai]]

How do I land this?
Lando says "repository is not supported by Lando"

Comment 6

[:glob ✱]

sheehan, can you please land this for arai?

Comment 7

[Connor Sheehan [:sheehan]]

Yes, I'll land this now. We will need a new release as well, which is probably overdue anyways. :)

Comment 8

[Connor Sheehan [:sheehan]]

Hm, I'm still seeing test failures in test_telemetry.py. It looks like when test_get_value would return nothing it throws an exception instead of returning None. arai, I'll land your patch and fix the test in a followup.

Edit: nevermind, you had it right after all. Patch will land shortly.