1771150 - Consider making fullscreen modal (preventing interaction with the rest of the page like modal dialogs do)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, task)

Description

[Emilio Cobos Álvarez [:emilio]]

Other browsers seem to do this, see https://bug1766093.bmoattachments.org/attachment.cgi?id=9278110 where you can't interact with the page below the backdrop.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1771150 - Make fullscreen modal. r=smaug

As per https://github.com/w3c/csswg-drafts/issues/7311.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a9bae22cf24
Make fullscreen modal. r=smaug

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 8a9bae22cf24 (Bug 1771150) for causing failures in browser_fullscreen_warning.js and test_pointerlock-api.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=UhqYPx4XQx--mS7vEr5N-A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8a9bae22cf24b465352fa2d9aa4a7408092a5e94

Log: https://treeherder.mozilla.org/logviewer?job_id=382623845&repo=autoland&lineNumber=5220 and also
https://treeherder.mozilla.org/logviewer?job_id=382625062&repo=autoland&lineNumber=5506 (https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-swr%2C13&tochange=66b6cbf778b08d4612ae35ff0a3ce96f09e1f6ac&fromchange=b66edd978d47d4f3c513c23edac2f65a83e78300&selectedTaskRun=VqqymHWURK67dqeWp9oExQ.1)

Backout: https://hg.mozilla.org/integration/autoland/rev/b52febc7b8fde1b02d445a4d7b608c2465f9dec9

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1771150 - Prevent the fullscreen / pointer-lock warning from being inert. r=Gijs,mconley

This allows the user to interact with them even in fullscreen, fixing
the test that got me backed out.

An alternative would be not to make fullscreen modal in chrome
documents, but seems better to be consistent and the fullscreen warning
is a very special case anyways.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfcf61dedb35
Make fullscreen modal. r=smaug

Comment 6

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/cfcf61dedb35