1771211 - Warning about missing scrollbar mediator in debug builds on about:preferences ("WARNING: '!sm', file widget/Theme.cpp:1055")

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Markus Stange [:mstange]]

STR:

1. Run a debug build.
2. Open about:preferences.
3. Look at the output in the console.

Expected results:
No warnings.

Actual results:

[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055
[Parent 17310, Main Thread] WARNING: '!sm', file /Users/mstange/code/mozilla/widget/Theme.cpp:1055

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1769012

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1769012, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

nsXULScrollFrame doesn't set the scrollbar mediator

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1771211 - Set scrollbar mediator on nsXULScrollFrame. r=mstange

Just like the ScrollReflowInput constructor does for nsHTMLScrollFrame.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92723f450afd
Set scrollbar mediator on nsXULScrollFrame. r=mstange

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/92723f450afd

Comment 7

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox debug build from treeherder (2020.05.25) on macOS 10.15.
I can confirm this issue is fixed, I verified using Firefox debug build from treeherder, on Firefox 102.0b7 did not see: "WARNING: '!sm', file widget/Theme.cpp:1055".