Closed Bug 1771277 Opened 3 years ago Closed 3 years ago

Remove the websocket and server sent events prefs

Categories

(DevTools :: Netmonitor, enhancement)

Product:
DevTools
Component:
Netmonitor
Version:
Firefox 86
Type:
enhancement

Tracking

(firefox103 fixed)

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1771277 - [devtools] Remove the websocket and server sent events prefs r=ochameau
48 bytes, text/x-phabricator-request
Details | Review

The prefs for Websockets and Server sent events have been enabled for a while now
devtools.netmonitor.features.webSockets
devtools.netmonitor.features.serverSentEvents

We should be able to get rid of them

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21c03813c9d0 [devtools] Remove the websocket and server sent events prefs r=ochameau

Backed out for causing multiple dt failures. Please also check the regressed bugs from this.

Push with failures

Failure log

Backout link

[task 2022-06-02T19:46:28.311Z] 19:46:28     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_console_enable_network_monitoring.js | setting is enabled - 
[task 2022-06-02T19:46:28.312Z] 19:46:28     INFO - Matched a message with text: "test-image.png?id=4", all messages received.
[task 2022-06-02T19:46:28.312Z] 19:46:28     INFO - Clear and close the Browser Console
[task 2022-06-02T19:46:28.312Z] 19:46:28     INFO - Clear the browser console output
[task 2022-06-02T19:46:28.312Z] 19:46:28     INFO - Browser console cleared
[task 2022-06-02T19:46:28.313Z] 19:46:28     INFO - Wait for all Browser Console targets to be attached
[task 2022-06-02T19:46:28.313Z] 19:46:28     INFO - Waiting 1 seconds.
[task 2022-06-02T19:46:28.313Z] 19:46:28     INFO - Close the Browser Console
[task 2022-06-02T19:46:28.313Z] 19:46:28     INFO - Browser Console closed
[task 2022-06-02T19:46:28.314Z] 19:46:28     INFO - Leaving test bound testEnableNetworkMonitoringInBrowserConsole
[task 2022-06-02T19:46:28.314Z] 19:46:28     INFO - Entering test bound testEnableNetworkMonitoringInWebConsole
[task 2022-06-02T19:46:28.314Z] 19:46:28     INFO - Adding a new tab with URL: data:text/html,<!DOCTYPE html><script>foo;</script>
[task 2022-06-02T19:46:28.314Z] 19:46:28     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-06-02T19:46:28.315Z] 19:46:28     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-06-02T19:46:28.315Z] 19:46:28     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-06-02T19:46:28.315Z] 19:46:28     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-06-02T19:46:28.316Z] 19:46:28     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-06-02T19:46:28.316Z] 19:46:28     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-06-02T19:46:28.317Z] 19:46:28     INFO - Console message: [JavaScript Error: "ReferenceError: foo is not defined" {file: "data:text/html,<!DOCTYPE html><script>foo;</script>" line: 1}]
[task 2022-06-02T19:46:28.317Z] 19:46:28     INFO - @data:text/html,<!DOCTYPE html><script>foo;</script>:1:1
[task 2022-06-02T19:46:28.317Z] 19:46:28     INFO - 
[task 2022-06-02T19:46:28.317Z] 19:46:28     INFO - Tab added and finished loading
[task 2022-06-02T19:46:28.317Z] 19:46:28     INFO - Opening the toolbox
[task 2022-06-02T19:46:28.318Z] 19:46:28     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome" line: 511}]
[task 2022-06-02T19:46:28.318Z] 19:46:28     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome" line: 511}]
[task 2022-06-02T19:46:28.318Z] 19:46:28     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome" line: 62}]
[task 2022-06-02T19:46:28.319Z] 19:46:28     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome" line: 511}]
[task 2022-06-02T19:46:28.319Z] 19:46:28     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome" line: 511}]
[task 2022-06-02T19:46:28.319Z] 19:46:28     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome" line: 62}]
[task 2022-06-02T19:46:28.320Z] 19:46:28     INFO - Buffered messages logged at 19:46:28
[task 2022-06-02T19:46:28.320Z] 19:46:28     INFO - Toolbox opened and focused
[task 2022-06-02T19:46:28.320Z] 19:46:28     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_console_enable_network_monitoring.js | The 'Enable Network Monitoring' setting item should not be avaliable in the webconsole - 
[task 2022-06-02T19:46:28.321Z] 19:46:28     INFO - Leaving test bound testEnableNetworkMonitoringInWebConsole
[task 2022-06-02T19:46:28.321Z] 19:46:28     INFO - Removing tab.
[task 2022-06-02T19:46:28.321Z] 19:46:28     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2022-06-02T19:46:28.322Z] 19:46:28     INFO - Got event: 'TabClose' on [object XULElement].
[task 2022-06-02T19:46:28.322Z] 19:46:28     INFO - Tab removed and finished closing
[task 2022-06-02T19:46:28.322Z] 19:46:28     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2022-06-02T19:46:28.323Z] 19:46:28     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_console_enable_network_monitoring.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2022-06-02T19:46:28.323Z] 19:46:28     INFO - Buffered messages finished
[task 2022-06-02T19:46:28.324Z] 19:46:28     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_console_enable_network_monitoring.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2022-06-02T19:46:28.324Z] 19:46:28     INFO - GECKO(2285) | MEMORY STAT | vsize 16353MB | residentFast 515MB | heapAllocated 156MB
[task 2022-06-02T19:46:28.325Z] 19:46:28     INFO - TEST-OK | devtools/client/webconsole/test/browser/browser_console_enable_network_monitoring.js | took 62263ms
[task 2022-06-02T19:46:28.325Z] 19:46:28     INFO - checking window state
[task 2022-06-02T19:46:28.325Z] 19:46:28     INFO - TEST-START | devtools/client/webconsole/test/browser/browser_console_error_source_click.js
Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d193aa033e1e [devtools] Remove the websocket and server sent events prefs r=ochameau

https://hg.mozilla.org/mozilla-central/rev/d193aa033e1e

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Flags: needinfo?(hmanilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: