1771339 - 'My vCard' attachment menu item in Compose/Write window should warn if underlying data is missing

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The 'My vCard' and 'My OpenPGP Public Key' attachment menu items in the Compose/Write window should warn if underlying data is missing. Right now they will switch to a checked state and the message can be sent without warning even if there is not vCard or OpenPGP key.

Comment 1

[Kai Engert (:KaiE:)]

I've fixed the OpenPGP key attachment in bug 1769212.

Let's morph this bug into a vcard problem bug.

Comment 2

[Kai Engert (:KaiE:)]

What's necessary for "attach my vCard" to work?

Comment 3

[Geoff Lankow (:darktrojan)]

Try the escapedVCard property of the identity in use. If there's nothing there… there's no vCard.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1771339 - Attach My vCard and My OpenPGP Key fixes. r=kaie

Comment 5

[Magnus Melin [:mkmelin]]

The fix for bug 1778939 was not fully correct: For identities A (sign+attach) and B (don't sign+attach). Switch from A to B and back to A: won't attach as it should. I conclude the attachPgpKey should always be adjusted, not only for certain cases.

Comment 6

[Kai Engert (:KaiE:)]

Comment on attachment 9285984 [details]
Bug 1771339 - Attach My vCard and My OpenPGP Key fixes. r=kaie

[Approval Request Comment]
Regression caused by (bug #): general openpgp composer enhancements for 102 not completely working yet
User impact if declined: unexpected message flags
Testing completed (on c-c, etc.): we need testing on beta, because we target 102
Risk to taking this patch (and alternatives if risky): low, only affects the flags that we're trying to fix

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f189c441a141
Attach My vCard and My OpenPGP Key fixes. r=kaie

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9285984 [details]
Bug 1771339 - Attach My vCard and My OpenPGP Key fixes. r=kaie

[Triage Comment]
Approved for beta

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9285984 [details]
Bug 1771339 - Attach My vCard and My OpenPGP Key fixes. r=kaie

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: see comment 5, and bug description
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): some risk

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9285984 [details]
Bug 1771339 - Attach My vCard and My OpenPGP Key fixes. r=kaie

[Triage Comment]
Approved for esr102

Comment 11

[Rob Lemley [:rjl]]

Magnus or Kai -- this is missing some dependencies on c-esr102 -- probably just bug 1778939. Can you request uplift?

Comment 12

[Magnus Melin [:mkmelin]]

Requested

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 102.1.1:
https://hg.mozilla.org/releases/comm-esr102/rev/eafdacc0c8b7