1771423 - Blob channel content type is a little non-standard if type is not set

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Description

[Dan Robertson (:dlrobertson)]

Given an empty blob with no type set, the Content-Type will be set to application/x-unknown-content.

var blob3 = new Blob([]);
fetch(url).then(function(resp) {
    assert_equals(resp.headers.get("Content-Type"), "application/x-unknown-content-type");
}

See whatwg/fetch#1436 for more details. Chome returns null and Safari returns "".

Comment 1

[Dan Robertson (:dlrobertson)]

Probably not a high priority, but was something I was interested in fixing (or attempting to fix) as a way to learn more about things.

Comment 2

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1771423 - Set Content-Type to an empty string for an blob with no type. r=kershaw,smaug,Gijs

Set the Content-Type to an empty string for an empty blob when the type was not
given.

Comment 3

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1771423 - Add test for fetching empty blobs. r=kershaw,smaug

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b7d886f374f
Add test for fetching empty blobs. r=kershaw,smaug
https://hg.mozilla.org/integration/autoland/rev/c1d1be434427
Set Content-Type to an empty string for an empty blob with no type. r=kershaw,smaug,necko-reviewers

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35469 for changes under testing/web-platform/tests

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2b7d886f374f
https://hg.mozilla.org/mozilla-central/rev/c1d1be434427

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out from Beta for 105.0b1 for causing bug 1786128. This change is still active in 106+.
https://hg.mozilla.org/releases/mozilla-beta/rev/672222c5bdc8

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/projects/pine-stable/rev/cbfecc44b37d
Backed out 2 changesets for causing bug 1786128.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35877 for changes under testing/web-platform/tests

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33609bd2549a
Backed out 2 changesets for causing webcompat regressions CLOSED TREE

Comment 12

[Norisz Fay [:noriszfay]]

Backed out per request for causing webcompat regressions

Backout link: https://hg.mozilla.org/integration/autoland/rev/33609bd2549a651c42a254d3c314aa28c6856710

Comment 13

[Dan Robertson (:dlrobertson)]

I'll move the work I was doing in bug 1786128 here.

Comment 14

[Sandor Molnar[:smolnar]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/33609bd2549a651c42a254d3c314aa28c6856710

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[Dan Robertson (:dlrobertson)]

Web platform tests from the attached patch merged upstream web-platform-tests/wpt#36243.

Comment 17

[Dan Robertson (:dlrobertson)]

Now that whatwg/fetch#1436 and whatwg/fetch#1464 are closed with the tests merged. There is a bit more clarity on how we should handle the empty content type. I'll re-open D147481 with the fix for the regressions listed.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/885d79011bc7
Set Content-Type to an empty string for an blob with no type. r=kershaw,smaug,Gijs

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/885d79011bc7