1771477 - Can't find word on Firefox PDF viewer

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[gybeom8008]

Attachment: bug.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

1. Open a Korean PDF: https://www.korean.go.kr/nkview/nklife/1998_4/1998_0402.pdf
2. Ctrl+F, and type, for instance: 박경래, which is apparantly the auther of this paper, written at the title.

Actual results:

It cannot locate nor highlight the right word, while it seems it can count the number of words.

Expected results:

It should be highlighted right under the title of the first chapter.

I don't know if it is Korean only issue, but it is reproduced on every Korean PDFs I have used, and failed to reproduced on any English PDFs I have.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::PDF Viewer' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Calixte Denizet (:calixte)]

It's a regression from:
https://github.com/mozilla/pdf.js/commit/1f41028fcbb21bd5af98810847d1892a51862bd0

Some characters in Korean are composed of several chars which are not diacritics

"특".normalize("NFD").split("") === [ "ᄐ", "ᅳ", "ᆨ" ]

and since we now normalize the text:
https://github.com/mozilla/pdf.js/blob/e6a0a953e840a16c02f48b373efcde4a92e4f963/web/pdf_find_controller.js#L138
those composed characters induce some unexpected shifting.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/14965

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/5b3fdee5f58a92d2516b3aa24fdd891878ea0f22

Commit merged into master by GitHub
Authored by calixteman (calixteman)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1754585

Comment 6

[Virgil Sangerean]

Reproduce with Firefox 100.
Issue is no longer reproducible on Firefox Nightly 104 from 29.06.2022.

Comment 7

[Virgil Sangerean]

Verified with 103.0b2