1771500 - [linux] Firefox does not show all the nearby printers

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[Jan Horak [:jhorak]]

0. stop cups-browsed service:

systemctl stop cups-browsed

1. Create multiple virtual printers on network (the ppd file has to be valid file):

sudo ippeveprinter -D file:/tmp/ps -P /usr/share/ppd/cupsfilters/Generic-PDF_Printer-PDF.ppd -c /usr/bin/cat "local_printer10"

2. Open print dialog
3. Only Save to PDF and one of the network or local printer is available to choose from.

The GTK dialog shows all the printers, libreoofice too (it has a own print dialog as Firefox has).

The problem is most likely with CupsDestCallback: https://searchfox.org/mozilla-central/source/widget/nsPrinterListCUPS.cpp#85
To continue enumerate all the printers it should return 1. For my case it returns 0, because the CUPS_DEST_FLAGS_MORE is not set. I think it is because some of the printers use ipps and other ipp:

avahi-browse -a|grep ipp                                                                                                                                                      15:33:09
+ wlp3s0 IPv6 local_printer10                               _ipps._tcp           local
+ wlp3s0 IPv6 local_printer9                                _ipps._tcp           local
+ wlp3s0 IPv4 local_printer9                                _ipps._tcp           local
+ wlp3s0 IPv4 local_printer10                               _ipps._tcp           local
+ wlp3s0 IPv6 local_printer10                               _ipp._tcp            local
+ wlp3s0 IPv6 local_printer9                                _ipp._tcp            local
+ wlp3s0 IPv4 Brother DCP-L2540DN series                    _ipp._tcp            local
+ wlp3s0 IPv4 local_printer10                               _ipp._tcp            local
+ wlp3s0 IPv4 local_printer9                                _ipp._tcp            local

I get the local_printer10 in the list sometimes and sometimes Brother DCP-L2540DN. So we should probably always return 1, because cups will handle the right iteration count for us.

Comment 1

[Jan Horak [:jhorak]]

Also the cups_get_cb which is used in CupsGetDests is always returning 1:
https://github.com/apple/cups/blob/23c45db76a8520fd6c3b1d9164dbe312f1ab1481/cups/dest.c#L4029

Comment 2

[Jan Horak [:jhorak]]

Attachment: Bug 1771500 Show all available printers; r?AlaskanEmily

Allow to continue enumeration of the printers for all protocols
(ie. ipp and ipps).

Comment 3

[Jan Horak [:jhorak]]

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1983403

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7bc35cb4c89
Show all available printers; r=stransky

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b7bc35cb4c89

Comment 6

[bukkeyjp]

I do not need all printers.
I would like to see a distinction between directly connected printers and network nearby printers.