Closed Bug 1771531 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34237 - CloseWatcher: group no-user-activation watchers with previous

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox103 fixed)

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34237 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34237
Details from upstream follow.

Domenic Denicola <domenic@chromium.org> wrote:

CloseWatcher: group no-user-activation watchers with previous

This follows the proposed spec change at https://github.com/WICG/close-watcher/pull/23, validating that it works as we'd hope via the implementation and corresponding web platform tests.

Bug: 1171318
Change-Id: I902d3238eb036284c8999409b96e351b3c3427cc
Reviewed-on: https://chromium-review.googlesource.com/3674036
WPT-Export-Revision: fef080461429ebc7a9f346c7d48ca240cdf3f162

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 16 subtests

Status Summary

Firefox

OK : 3
FAIL : 29

Chrome

OK : 1
FAIL : 1
ERROR: 2

Safari

OK : 3
FAIL : 29

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /close-watcher/basic.html [wpt.fyi]
    • close() with no user activation only fires close: FAIL (Safari: FAIL)
    • destroy() then close() fires no events: FAIL (Safari: FAIL)
    • close() then destroy() fires only one close event: FAIL (Safari: FAIL)
    • Esc key does not count as user activation, so it fires close but not cancel: FAIL (Safari: FAIL)
    • destroy() then close via Esc key fires no events: FAIL (Safari: FAIL)
    • Esc key then destroy() fires only one close event: FAIL (Safari: FAIL)
    • close via synthesized escape key should not work: FAIL (Safari: FAIL)
    • destroy inside oncancel: FAIL (Safari: FAIL)
    • destroy inside onclose is benign: FAIL (Safari: FAIL)
    • close inside oncancel should not trigger an infinite loop: FAIL (Safari: FAIL)
    • close inside onclose should not trigger an infinite loop: FAIL (Safari: FAIL)
    • close with events added via addEventListener: FAIL (Safari: FAIL)
  • /close-watcher/user-activation-multiple-plus-free.html [wpt.fyi]
    • Multiple CloseWatchers created from a single user activation close together, but original free CloseWatcher closes separately: FAIL (Chrome: FAIL, Safari: FAIL)
  • /close-watcher/user-activation.html [wpt.fyi]
    • CloseWatchers created without user activation, but close()d via user activation, fires cancel: FAIL (Safari: FAIL)
    • CloseWatchers created without user activation, but close()d via user activation, fires cancel, which can be preventDefault()ed: FAIL (Safari: FAIL)
    • CloseWatchers created without user activation, but closed via a close signal after user activation, fires cancel: FAIL (Safari: FAIL)
    • CloseWatchers created without user activation, but closed via a close signal after user activation, fires cancel, which can be preventDefault()ed: FAIL (Safari: FAIL)
    • Multiple CloseWatchers created without user activation close together (with no cancel): FAIL (Safari: FAIL)
    • Creating a CloseWatcher from user activation keeps it separate from the free CloseWatcher, but they don't fire cancel: FAIL (Safari: FAIL)
    • Creating a CloseWatcher from user activation, and close()ing CloseWatchers with user activation, fires cancel: FAIL (Safari: FAIL)
    • Creating a CloseWatcher from user activation, and closing CloseWatchers with a close signal after user activation, fires cancel: FAIL (Safari: FAIL)
    • Multiple CloseWatchers created with user activation close in reverse order: FAIL (Safari: FAIL)
    • 3 user activations let you have 3 + 1 = 4 ungrouped close watchers/0 cancel events: FAIL (Safari: FAIL)
    • 3 user activations let you have 2 close watchers with 1 cancel event, even if the first cancel event is prevented: FAIL (Safari: FAIL)
    • destroy()ing the free CloseWatcher allows a new free one to be created without user activation, and it receives the close signal: FAIL (Safari: FAIL)
    • close()ing the free CloseWatcher allows a new free one to be created without user activation, and it receives the close signal: FAIL (Safari: FAIL)
    • closing the free CloseWatcher via a close signal allows a new free one to be created without user activation, and it receives a second close signal: FAIL (Safari: FAIL)
    • The second watcher can be the free watcher, if the first is created with user activation: FAIL (Safari: FAIL)
    • The third watcher can be the free watcher, if the first two are created with user activation: FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ea9e11aa1fe [wpt PR 34237] - CloseWatcher: group no-user-activation watchers with previous, a=testonly https://hg.mozilla.org/integration/autoland/rev/2b801a50d7a5 [wpt PR 34237] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9ea9e11aa1fe
https://hg.mozilla.org/mozilla-central/rev/2b801a50d7a5

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.