177162 - [PatchReader] Make Patch Viewer Root Recognition Smart

Status: RESOLVED INVALID

(Bugzilla :: Attachments & Requests, defect, P3)

Description

[John Keiser (jkeiser)]

Patch Viewer assumes one root (and may allow the admin to specify multiple) but
there should be a way for it to determine automatically what the root of a patch
is without admin intervention.  Suggestions:

1. (timeless) traverse up / down the RCS path searching for the file in Bonsai
until you find a root
2. (timeless) to speed up the above operation, keep a list of the roots you have
found and check them against a CVS root; when you find a match, ensure the first
file is in Bonsai and if not, fall back to method (1).
3. In the absence of an RCS path, use Bonsai to determine the relative location
of a file (not foolproof, but in most patches there should be a unique
file--patches modifying Makefile.in often modify something else).
4. In the absence of an RCS path, recognize the case of "diff old/path_to_file
new/path_to_file" and strip off old and new before trying step (3).

Comment 1

[John Keiser (jkeiser)]

Note that Patch Viewer is not in yet.  Setting dependent.

Comment 2

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 3

[Frédéric Buclin]

We have no control on PatchReader on CPAN, and bugs should be reported to rt.cpan.org.