1771718 - Tweak idle scheduling to support high frame rates better

Status: RESOLVED FIXED

(Core :: General, enhancement)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdd5393f91f986edb26a73ab8bd3944b098e333c

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1771718, nsRefreshDriver::IsInHighRateMode(), r=mstange

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1771718, let idle period be shorter when frame rate is very high, r=farre

Depends on D147642

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1771718, let GC and CC to use shorter (idle) slices when frame rate is high, r=jonco,mccr8

This approach tweaks only the idle handling part. We may want to reduce the length of non-idle
slices too, but that is somewhat separate issue.

Depends on D147643

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1771718, remove idle time limit from SessionSaver.jsm, r=mconley

The limit without a separate timeout to guarantee the callback will be called eventually doesn't really work.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1763839#c8
And 5ms jank isn't too bad.

Depends on D147644

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cea657e12ad1
nsRefreshDriver::IsInHighRateMode(), r=mstange
https://hg.mozilla.org/integration/autoland/rev/02f41c069f40
let idle period be shorter when frame rate is very high, r=farre
https://hg.mozilla.org/integration/autoland/rev/46c6d357568e
let GC and CC to use shorter (idle) slices when frame rate is high, r=jonco,mccr8
https://hg.mozilla.org/integration/autoland/rev/51dcf42bd3d7
remove idle time limit from SessionSaver.jsm, r=mconley

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cea657e12ad1
https://hg.mozilla.org/mozilla-central/rev/02f41c069f40
https://hg.mozilla.org/mozilla-central/rev/46c6d357568e
https://hg.mozilla.org/mozilla-central/rev/51dcf42bd3d7

Comment 9

[Markus Stange [:mstange]]

Is this worth putting into the 103 release notes, along the lines of "Improved performance on high-refresh rate monitors (140Hz+)"?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

I think the patch ended up affect 120+, but yes. Feedback in bug 1764578 was rather positive.

Release Note Request (optional, but appreciated)
Changes in this bug affect FF 103

[Why is this notable]:
Certain websites, like Youtube , use requestIdleCallback API and it didn't work too well with very high refresh rate monitors.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1764578#c23

[Affects Firefox for Android]:
If there are very high refresh rate Android devices and we expose that rate to the web, then yes...
I was told we do expose high refresh rates on Android too

[Suggested wording]:
"Improved performance on high-refresh rate monitors (120Hz+)"

[Links (documentation, blog post, etc)]:

Comment 11

[Donal Meehan [:dmeehan]]

Note added to 103 nightly release notes.