177176 - Registering and unregistering as app-startup observer behaves strange

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Pavol Vaskovic]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021016
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021016

I'm unable to register (and unregister) as app-startup observer in Category
Manager at other time than module registration (MozgestModule.registerSelf) in
mozilla 1.2b.

I've done this change:
http://www.mozdev.org/source/browse/optimoz/mozgestService/service/mozgest-service.js.diff?r1=1.1&r2=1.2

and tried to register from preference screen with code:

function setStartup(onStartup) {
  const MOZGEST_CONTRACTID = "@optimoz.mozdev.org/mozgest;1";
  const CATMAN_CONTRACTID = "@mozilla.org/categorymanager;1";
  const nsICategoryManager = Components.interfaces.nsICategoryManager;
  var catMan = Components.classes[CATMAN_CONTRACTID].getService(nsICategoryManager);
  if (onStartup) {
    dump("*** Mozgest JS Service will be started on Startup\n");
    catMan.addCategoryEntry("app-startup",
                            "Mozgest observing Startup",
                            MOZGEST_CONTRACTID,
                            true,
                            true);
  }
  else {
    dump("*** Mozgest JS Service will NOT be started on Startup\n");
    catMan.deleteCategoryEntry("app-startup",
                               MOZGEST_CONTRACTID,
                               true);
  }
}

But this does niether register my JS service - see
http://www.mozdev.org/source/browse/optimoz/mozgestService/service/ - when
registered at module registration, nor does it unregister my service in case it
was not registered with module.
I didn't get any exception, nor JS error.

And I'm not sure if it's related, but the module does not reregister itself when
it is replaced with newer file, which it did in 1.0 - 1.2a.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Robert Ginda]

Venkman is also unable to unregister its app-startup observer.  It appears that
the code executes, and removes the observer for the duration of the session, but
the observer is never deleted from compreg.dat.  The next time mozilla starts
up, the observer is still there.  The code in question is
http://lxr.mozilla.org/mozilla/source/js/jsd/jsd_xpc.cpp#2323 

Comment 2

[Doug Turner (:dougt)]

Attachment: fixes problem

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 104542 [details] [diff] [review]
fixes problem

r=rginda via email

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 104542 [details] [diff] [review]
fixes problem

sr=dveditz

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 104542 [details] [diff] [review]
fixes problem

a=roc+moz for trunk

Comment 6

[Doug Turner (:dougt)]

fixed.