1771822 - Clean up obsolete or unnecessary prefs set when running APZ tests

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1771822 - Remove the browser.chrome.dynamictoolbar pref. r=tnikkel

This pref is left over from a previous dynamic toolbar implementation,
and no one was reading its value.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1771822 - Do not explicitly set dom.visualviewport.enabled in tests. r=tnikkel

This pref is now enabled by default on all platforms.

Depends on D147810

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/493bb853cb56
Remove the browser.chrome.dynamictoolbar pref. r=tnikkel,perftest-reviewers,AlexandruIonescu
https://hg.mozilla.org/integration/autoland/rev/a6d9ec5a481e
Do not explicitly set dom.visualviewport.enabled in tests. r=tnikkel

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/493bb853cb56
https://hg.mozilla.org/mozilla-central/rev/a6d9ec5a481e

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1771822 - Do not explicitly set apz.allow_zooming in mochitests. r=tnikkel

We can't do likewise for reftests and web platform tests because
those test suites disable apz.allow_zooming by default on android.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a598b1533e6
Do not explicitly set apz.allow_zooming in mochitests. r=tnikkel

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0a598b1533e6

Comment 8

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #5)

We can't do likewise for reftests and web platform tests because
those test suites disable apz.allow_zooming by default on android.

By the way, I did check to see how many reftests fail on Android with apz.allow_zooming enabled, looks like it's a few dozen.

It might be a good idea to change the Android default to apz.allow_zooming=true and disable it only for the specific tests that need it, until we investigate those failures; that way, at least new reftests get Android coverage with zooming enabled.

However, I don't know of a way to disable apz.allow_zooming for those tests on Android only; pref(apz.allow_zooming,false) in the reftest.list file would disable zooming on all platforms for those tests. Not sure if that would be an improvement in terms of test coverage...

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1771822 - Do not explicitly set some other prefs, which are now always enabled, in tests. r=tnikkel

The prefs handled in this patch are:

apz.paint_skipping.enabled
apz.force_disable_desktop_zooming_scrollbars
apz.mac.enable_double_tap_zoom_touchpad_gesture
dom.event.default_to_passive_touch_listeners
dom.visualviewport.enabled (one use left over)

Comment 10

[Botond Ballo [:botond]]

Attachment: Bug 1771822 - Remove the apz.minimap.enabled pref. r=tnikkel

It's currently unused.

Depends on D151795

Comment 11

[Botond Ballo [:botond]]

Attachment: Bug 1771822 - Remove the layers.low-precision-{buffer,resolution} prefs. r=tnikkel

These are no longer used.

Depends on D151796

Comment 12

[Botond Ballo [:botond]]

Attachment: Bug 1771822 - Follow-up simplifications to DisplayPortUtils functions. r=tnikkel

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0c7abb73386
Do not explicitly set some other prefs, which are now always enabled, in tests. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/af7f68944b4f
Remove the apz.minimap.enabled pref. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/f41c9ad861cd
Remove the layers.low-precision-{buffer,resolution} prefs. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/937db60c3c63
Follow-up simplifications to DisplayPortUtils functions. r=tnikkel

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b0c7abb73386
https://hg.mozilla.org/mozilla-central/rev/af7f68944b4f
https://hg.mozilla.org/mozilla-central/rev/f41c9ad861cd
https://hg.mozilla.org/mozilla-central/rev/937db60c3c63