1771823 - Firefox clears the system clipboard when the application exits

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Chris Peterson [:cpeterson]]

This bug is a regression in Firefox 101 from bug 666254.

Makoto, your fix for bug 666254 causes Firefox on macOS to clear the system clipboard when you exit Firefox. Is clearing the system clipboard intentional? Firefox on Windows doesn't do this when it exits and neither Chrome nor Safari on macOS do they exit.

Steps to reproduce

1. Open a page in Firefox version >= 101 on macOS.
2. Copy some text from the page. Paste the copied text into another application to verify that the text was successfully copied.
3. Quit Firefox.
4. Try to paste the copied text into the other application again.

Expected result

You should be able to paste the copied text into the other application again.

Actual result

You can't paste the copied text into the other application again because Firefox cleared the system clipboard when it exits. Firefox on Windows doesn't do this when it exits, only Firefox on macOS.

Comment 1

[Makoto Kato [:m_kato]]

https://searchfox.org/mozilla-central/rev/32ca4fc265150e7d3d7aa6c6abea088768cf024b/widget/cocoa/nsClipboard.mm#66-67 seems to be unnecessary.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=#mac-reviewers

This is regression by bug 666254. We shouldn't call
nsClipborad::EmptyClipboard() in destructor. Cached nsITransferable will
be cleared by nsBaseClipboard()'s destructor.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Seems like something we'd probably want to consider taking in a dot release.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcab49b12871
Don't clear system clipboard when exiting Firefox. r=mac-reviewers,spohl

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fcab49b12871

Comment 6

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

Setting status-firefox101=fix-optional. I don't think this regression is serious enough to drive a 101.x dot release, but it might be a good candidate for a ride-along. I do think we should uplift this fix to Beta 102 and ESR 102.

Comment 7

[Pascal Chevrel:pascalc]

Please request the uplift to beta, thanks.

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 9279051 [details]
Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=#mac-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: When exiting Firefox, system's clipboard becomes empty
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open any web site

2. Copy any word using [Command] + [C]
3. Quit Firefox
4. Paste text to any application

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Remove unnecessary cleanup of clipboard.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 102.0b1(20220530132252) on macOS 11. Verified as fixed on Nightly 103.0a1(20220605213032) on macOS 11.

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 9279051 [details]
Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=#mac-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: When exiting Firefox, system's clipboard becomes empty
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open any web site

2. Copy any word using [Command] + [C]
3. Quit Firefox
4. Paste text to any application

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Remove unnecessary cleanup of clipboard.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9279051 [details]
Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=#mac-reviewers

Approved for 102 beta 5, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/6b7caf4b0c9b

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello,
I confirm the fix is verified on Firefox 102.0b5(20220607212916) on macOS 11.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9279051 [details]
Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=#mac-reviewers

Approved for 101.0.1.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/a2e465fa1db7

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Added to the 101.0.1 relnotes:

Fixed Firefox clearing the clipboard when closing on macOS

Comment 17

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello,
I confirm this fix is verified on Firefox 101.0.1(20220608170832) on macOS 11.

Comment 18

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello, I confirm this fix is verified on Firefox 102esr(20220623064521) on macOS 11.

Comment 19

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello,
I encountered this error in Firefox 103.0b7 on Ubuntu 22.04. This is not reproducible is Firefox 103.0b6, nor the latest nightly. Should I file a new bug for Ubuntu?

Comment 20

[Makoto Kato [:m_kato]]

(In reply to Ardelean Oana from comment #19)

Hello,
I encountered this error in Firefox 103.0b7 on Ubuntu 22.04. This is not reproducible is Firefox 103.0b6, nor the latest nightly. Should I file a new bug for Ubuntu?

Yes, please file new issue.