1772001 - Enterprise policy for tmp folder downloads uses the wrong pref

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
ESR release should have working enterprise policy.

See bug 1738574 comment 135.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1772001 - fix enterprise policy for using the temp folder for downloads, r?mkaply,evilpie

Comment 2

[:Gijs (he/him)]

Comment on attachment 9279008 [details]
Bug 1772001 - fix enterprise policy for using the temp folder for downloads, r?mkaply,evilpie

Beta/Release Uplift Approval Request

• User impact if declined: Enterprise policy for tmp folder downloads doesn't work
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Verify enterprise policy (StartDownloadsInTempDirectory) works to put downloads opened in an external app in the tmp folder (check by setting some file type to auto open, and by defaulting back to the dialog using the UI added in bug 1747343).
• List of other uplifts needed: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1-character patch. The rest is automated tests.
• String changes made/needed: No
• Is Android affected?: No

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/646e8200e2d5
fix enterprise policy for using the temp folder for downloads, r=mkaply

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/646e8200e2d5

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9279008 [details]
Bug 1772001 - fix enterprise policy for using the temp folder for downloads, r?mkaply,evilpie

Approved for 102 beta 3, thanks!

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab2241743e14

Comment 7

[Mike Kaply [:mkaply]]

This shouldn't need a separate uplift for ESR 102, should it?

Comment 8

[Pascal Chevrel:pascalc]

(In reply to Mike Kaply [:mkaply] from comment #7)

This shouldn't need a separate uplift for ESR 102, should it?

No, we will be merging 102 into the 102esr branch regularly during the beta cycle, ESR102 specific uplifts that may differ from the regular 102 release will be uplifted towards the end of the beta cycle.

Comment 9

[Adrian Florinescu [:aflorinescu]]

Same STR as for verification done with 102.0b3 on Windows 10, Mac 11 and Ubuntu 22.04 + Ubuntu 21.10 in bug 1738574 but with the policy enabled.

Same note for the snap builds as in bug 1738574.

Leaving the qe+ for Nightly verification + additional snap investigation as well.

Comment 10

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 102.0esr 2022-06-20 and 103.0a1 2022-06-20 on Windows 10, Ubuntu 22.04 and Mac 11.